Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152647

[libc++][spaceship] P1614R2: Added `operator==` to `file_status`
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 11 2023, 12:55 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGa9e0321ffed1: [libc++][spaceship] P1614R2: Added `operator==` to `file_status`
Summary

Implemented parts of P1614R2:

  • Added operator== to file_status

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 11 2023, 12:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 12:55 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
Harbormaster completed remote builds in B238020: Diff 530288.Jun 11 2023, 1:08 AM
H-G-Hristov updated this revision to Diff 530290.Jun 11 2023, 1:34 AM

Try to fix CI

Harbormaster completed remote builds in B238022: Diff 530290.Jun 11 2023, 3:01 AM
H-G-Hristov updated this revision to Diff 530315.Jun 11 2023, 11:29 AM

Try to fix CI

Harbormaster completed remote builds in B238040: Diff 530315.Jun 11 2023, 4:33 PM
H-G-Hristov published this revision for review.Jun 11 2023, 10:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 10:57 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
H-G-Hristov added a reviewer: Mordante.Jun 11 2023, 10:59 PM
Mordante accepted this revision.Jun 12 2023, 9:16 AM

LGTM!

libcxx/include/filesystem
251–275

Thanks!

This revision is now accepted and ready to land.Jun 12 2023, 9:16 AM
Closed by commit rGa9e0321ffed1: [libc++][spaceship] P1614R2: Added `operator==` to `file_status` (authored by Zingam). · Explain WhyJun 12 2023, 9:54 AM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rGa9e0321ffed1: [libc++][spaceship] P1614R2: Added `operator==` to `file_status`.

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
4 lines
include/
__filesystem/
8 lines
26 lines
test/
std/
input.output/
filesystems/
class.file_status/
54 lines

Diff 530561

View Options

libcxx/docs/Status/SpaceshipProjects.csv

Loading...
View Options

libcxx/include/__filesystem/file_status.h

Loading...
View Options

libcxx/include/filesystem

Loading...
View Options

libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp

Loading...