Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D152642

[libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 10 2023, 10:29 PM.

Details

Reviewers

Mordante

Group Reviewers

Restricted Project

Commits

rG3d74398bd33b: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`…

Summary

Implements parts of P1614R2:

Removed ops from unordered_map
Removed ops from unordered_multimap
Removed ops from __hash_map_iterator

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

H-G-Hristov created this revision.Jun 10 2023, 10:29 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 10:29 PM

Herald added a subscriber: yaxunl. · View Herald Transcript

Updated table

Harbormaster completed remote builds in B238006: Diff 530273.Jun 11 2023, 3:48 AM

H-G-Hristov published this revision for review.Jun 11 2023, 9:41 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 9:41 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Thanks LGTM, modulo one nit.

libcxx/include/unordered_map
958	Can you mention this is the commit message too?

This revision is now accepted and ready to land.Jun 11 2023, 11:04 AM

H-G-Hristov edited the summary of this revision. (Show Details)Jun 11 2023, 11:23 AM

H-G-Hristov retitled this revision from [libc++][spaceship] P1614R2: Removed ops from `unordered_map`, `unordered_multimap` to [libc++][spaceship] P1614R2: Removed ops from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`.Jun 11 2023, 11:26 AM

Rebased

H-G-Hristov retitled this revision from [libc++][spaceship] P1614R2: Removed ops from `unordered_map`, `unordered_multimap`, `__hash_map_iterator` to [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`.Jun 11 2023, 12:08 PM

Harbormaster completed remote builds in B238042: Diff 530319.Jun 11 2023, 5:46 PM

Closed by commit rG3d74398bd33b: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`… (authored by Zingam). · Explain WhyJun 11 2023, 11:23 PM

This revision was automatically updated to reflect the committed changes.

Zingam added a commit: rG3d74398bd33b: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`….