This is an archive of the discontinued LLVM Phabricator instance.

Differential D152470

[libc][NFC] land long double table for printf
ClosedPublic

Authored by michaelrj on Jun 8 2023, 2:28 PM.

Details

Reviewers
sivachandra
lntue
Commits
rG47fd67ec34fe: [libc][NFC] land long double table for printf
Summary

The Mega Table that printf uses for long doubles with some flags is too
large for the linters, and so has been split out from the main patch.
The main patch: https://reviews.llvm.org/D150399

Diff Detail

Event Timeline

michaelrj created this revision.Jun 8 2023, 2:28 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 8 2023, 2:28 PM
Herald added a subscriber: libc-commits. · View Herald Transcript
michaelrj requested review of this revision.Jun 8 2023, 2:28 PM
michaelrj added reviewers: sivachandra, lntue.Jun 8 2023, 2:28 PM
sivachandra accepted this revision.Jun 8 2023, 2:43 PM
This revision is now accepted and ready to land.Jun 8 2023, 2:43 PM
Harbormaster completed remote builds in B237589: Diff 529729.Jun 8 2023, 2:46 PM
This revision was landed with ongoing or failed builds.Jun 8 2023, 4:15 PM
Closed by commit rG47fd67ec34fe: [libc][NFC] land long double table for printf (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG47fd67ec34fe: [libc][NFC] land long double table for printf.

Revision Contents

PathSize
libc/
src/
__support/
119867 lines
stdio/
printf_core/
4 lines
utils/
bazel/
llvm-project-overlay/
libc/
3 lines

Diff 529766

libc/src/__support/ryu_long_double_constants.h

This file has a very large number of changes (119,867 lines). Show File Contents

libc/src/stdio/printf_core/CMakeLists.txt

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines DEPENDS
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.fenv_impl libc.src.__support.FPUtil.fenv_impl
libc.src.__support.common libc.src.__support.common
libc.src.__support.libc_assert libc.src.__support.libc_assert
libc.src.__support.uint libc.src.__support.uint
libc.src.__support.uint128 libc.src.__support.uint128
libc.src.__support.integer_to_string libc.src.__support.integer_to_string
libc.src.__support.float_to_string libc.src.__support.float_to_string
# COMPILE_OPTIONS COMPILE_OPTIONS
# -DLIBC_COPT_FLOAT_TO_STR_USE_MEGA_LONG_DOUBLE_TABLE -DLIBC_COPT_FLOAT_TO_STR_USE_MEGA_LONG_DOUBLE_TABLE
) )
add_object_library( add_object_library(
printf_main printf_main
SRCS SRCS
printf_main.cpp printf_main.cpp
HDRS HDRS
Show All 39 Lines

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

Show First 20 Lines • Show All 306 Lines • ▼ Show 20 Lines
libc_support_library( libc_support_library(
name = "__support_float_to_string", name = "__support_float_to_string",
hdrs = [ hdrs = [
"src/__support/float_to_string.h", "src/__support/float_to_string.h",
"src/__support/ryu_constants.h", "src/__support/ryu_constants.h",
"src/__support/ryu_long_double_constants.h", "src/__support/ryu_long_double_constants.h",
], ],
# This is temporarily commented out since the table is too large to land in the same patch as the rest of the changes. defines = ["LIBC_COPT_FLOAT_TO_STR_USE_MEGA_LONG_DOUBLE_TABLE"],
# defines = ["LIBC_COPT_FLOAT_TO_STR_USE_MEGA_LONG_DOUBLE_TABLE"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_cpp_type_traits", ":__support_cpp_type_traits",
":__support_fputil_dyadic_float", ":__support_fputil_dyadic_float",
":__support_fputil_fp_bits", ":__support_fputil_fp_bits",
":__support_libc_assert", ":__support_libc_assert",
":__support_uint", ":__support_uint",
":libc_root", ":libc_root",
▲ Show 20 Lines • Show All 2,307 Lines • Show Last 20 Lines