This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Remove outdated TODO for `Type::getPointerTo`
AbandonedPublic

Authored by JOE1994 on Jun 5 2023, 8:53 AM.

Details

Reviewers
None
Summary

D104718 (commit 7bb7fa12e73b) introduced the TODO comment, along with
code for opaque pointer handling in Type::getPointerTo.

Later, D104902 (commit 1e6303e60ca5) removed the separate opaque pointer
handling code in Type::getPointerTo. Thus, getting rid of
Type::getPointerTo seems no longer unnecessary.

Diff Detail

Event Timeline

JOE1994 created this revision.Jun 5 2023, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 8:53 AM
JOE1994 requested review of this revision.Jun 5 2023, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 8:53 AM
JOE1994 updated this revision to Diff 528467.Jun 5 2023, 8:55 AM

Minor fix to commit message.

nikic added a subscriber: nikic.Jun 5 2023, 8:56 AM

The TODO is still relevant. This method will be removed when migration finishes, as it is no longer needed.

The TODO is still relevant.

Since the function getPointerTo was added back in 2015 (commit 84a138a351d665332477e807b4292c1b1f7dd523),
I assumed that the sole motivation for removing getPointerTo is because of the extra code block for handling opaque pointers.

If the plan is to eventually get rid of getPointerTo, so I'll close this revision.

JOE1994 abandoned this revision.Jun 5 2023, 9:10 AM