This is an archive of the discontinued LLVM Phabricator instance.

Differential D152099

[libc++] Removes CMake work-arounds.
ClosedPublic

Authored by Mordante on Jun 4 2023, 8:40 AM.

Details

Reviewers
jloser
philnik
Group Reviewers
Restricted Project
Commits
rGf26b43fa5cc7: [libc++] Removes CMake work-arounds.
Summary

CMake older than 3.20.0 is no longer supported.
This removes work-arounds for no longer supported versions.

Diff Detail

Event Timeline

Mordante created this revision.Jun 4 2023, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2023, 8:40 AM
Mordante requested review of this revision.Jun 4 2023, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2023, 8:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B236465: Diff 528222.Jun 4 2023, 12:35 PM
jloser accepted this revision.Jun 4 2023, 9:26 PM
Mordante mentioned this in D152103: [LLVM] Removes CMake work-arounds..Jun 5 2023, 9:05 AM
philnik accepted this revision.Jun 5 2023, 9:19 AM
This revision is now accepted and ready to land.Jun 5 2023, 9:19 AM
Closed by commit rGf26b43fa5cc7: [libc++] Removes CMake work-arounds. (authored by Mordante). · Explain WhyJun 5 2023, 11:10 PM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGf26b43fa5cc7: [libc++] Removes CMake work-arounds..

Revision Contents

PathSize
libcxx/
benchmarks/
5 lines

Diff 528692

libcxx/benchmarks/CMakeLists.txt

if (CMAKE_VERSION VERSION_LESS 3.17)
message(WARNING "The libc++ benchmarks won't be available because the version of CMake is too old to support them.")
return()
endif()
include(ExternalProject) include(ExternalProject)
include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
#============================================================================== #==============================================================================
# Build Google Benchmark for libc++ # Build Google Benchmark for libc++
#============================================================================== #==============================================================================
set(CMAKE_FOLDER "${CMAKE_FOLDER}/Benchmarks") set(CMAKE_FOLDER "${CMAKE_FOLDER}/Benchmarks")
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines