This is an extension and only adds the functions that are a considered a
but when called and ignoring the result.
Drive-by sort all nodiscard extensions in the documentation.
Paths
| Differential D152097
[libc++][format] Make public functions nodiscard. ClosedPublic Authored by Mordante on Jun 4 2023, 8:35 AM.
Details
Summary This is an extension and only adds the functions that are a considered a Drive-by sort all nodiscard extensions in the documentation.
Diff Detail
Event Timelinephilnik added inline comments. This revision now requires changes to proceed.Jun 8 2023, 10:02 AM Comment Actions Thanks for the review!
philnik added inline comments.
This revision is now accepted and ready to land.Jun 12 2023, 8:04 AM Comment Actions Thanks for the review!
Closed by commit rG9c053e69939b: [libc++][format] Make public functions nodiscard. (authored by Mordante). · Explain WhyJun 12 2023, 9:56 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 528243 libcxx/docs/UsingLibcxx.rst
libcxx/include/__format/format_functions.h
libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp
libcxx/test/std/utilities/format/format.arguments/format.arg.store/make_format_args.sh.cpp
libcxx/test/std/utilities/format/format.functions/format.locale.verify.cpp
libcxx/test/std/utilities/format/format.functions/format.verify.cpp
libcxx/test/std/utilities/format/format.functions/formatted_size.locale.verify.cpp
libcxx/test/std/utilities/format/format.functions/formatted_size.verify.cpp
libcxx/test/std/utilities/format/format.tuple/format.functions.format.verify.cpp
|
You seem to be missing a positive test.