This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Add 'inline' to static secondary.h function
ClosedPublic

Authored by Caslyn on Jun 2 2023, 3:19 PM.

Details

Summary

This patches an error flaged by Fuchsia builds when trying to roll https://reviews.llvm.org/D150481 e.g.
https://ci.chromium.org/ui/p/turquoise/builders/global.try/core.x64-asan/b8779376650819379137/overview)

../../third_party/scudo/src/secondary.h:67:13: error: 'static' function 'unmap' declared in header file should be declared 'static inline' [-Werror,-Wunneeded-internal-declaration]
static void unmap(LargeBlock::Header *H) {
            ^
1 error generated.

Diff Detail

Event Timeline

Caslyn created this revision.Jun 2 2023, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2023, 3:19 PM
Caslyn requested review of this revision.Jun 2 2023, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2023, 3:19 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Caslyn updated this revision to Diff 528016.Jun 2 2023, 3:23 PM

Provide full error message in comment

Caslyn edited the summary of this revision. (Show Details)Jun 2 2023, 3:25 PM
Caslyn added a reviewer: fabio-d.
Chia-hungDuan accepted this revision.Jun 2 2023, 4:41 PM
This revision is now accepted and ready to land.Jun 2 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.