This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Move -nostdinc like options into IncludePath_Group
ClosedPublic

Authored by MaskRay on Jun 1 2023, 3:15 PM.

Details

Summary

With only a link action, we claim all CompileOnly_Group options (including -f*,
-m*, -i*, etc). It makes sense to claim -nostdinc family options as well.
We can achieve this by placing these options into IncludePath_Group, a derivative of
CompileOnly_Group.

Diff Detail

Event Timeline

MaskRay created this revision.Jun 1 2023, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 3:15 PM
MaskRay requested review of this revision.Jun 1 2023, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 3:15 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay updated this revision to Diff 527645.Jun 1 2023, 3:18 PM

Include -nobuiltininc

theuni accepted this revision.Jun 1 2023, 3:43 PM

Looks good to me. I can confirm that this fixes my test-case from D151926.

This revision is now accepted and ready to land.Jun 1 2023, 3:43 PM