[libcxx] __support: Implement strtol_l() / strtoul_l() consistently

[Mordante]

Summary

• Move fallback functions for strtol_l() and strtoul_l() to __strtonum_fallback.h.
• Add strtoul_l() for older Android.
• Windows provides _strtol_l and _strtoul_l.

[philnik]

It looks like we don't actually use strtol_l or strtoul_l anywhere, so we might as well just remove these functions.

[Mordante]

Since this patch is inactive and we're moving to GitHub PR's closing this patch.

libcxx/include/__support/android/locale_bionic.h

 inline _LIBCPP_HIDE_FROM_ABI_C double strtod_l(const char* __nptr, char** __endptr, locale_t) {
   return ::strtod(__nptr, __endptr);
 }
 
 inline _LIBCPP_HIDE_FROM_ABI_C long strtol_l(const char* __nptr, char** __endptr, int __base, locale_t) {
   return ::strtol(__nptr, __endptr, __base);
 }
 
+inline _LIBCPP_HIDE_FROM_ABI_C unsigned long strtoul_l(const char* __nptr, char** __endptr, int __base, locale_t) {
+  return ::strtoul(__nptr, __endptr, __base);
+}
+
 #if defined(__cplusplus)
 }
 #endif
 
 #endif // __ANDROID_API__ < 26
 
 #endif // __NDK_MAJOR__ <= 16
 #endif // __has_include(<android/ndk-version.h>)
 #endif // defined(__ANDROID__)
 
 #endif // defined(__BIONIC__)
 #endif // _LIBCPP___SUPPORT_ANDROID_LOCALE_BIONIC_H

libcxx/include/__support/musl/xlocale.h

 
 #include <cstdlib>
 #include <cwchar>
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 
+inline _LIBCPP_HIDE_FROM_ABI_C long strtol_l(const char* __nptr, char** __endptr, int __base, locale_t) {
+  return ::strtol(__nptr, __endptr, __base);
+}
+
 inline _LIBCPP_HIDE_FROM_ABI_C long long strtoll_l(const char* __nptr, char** __endptr, int __base, locale_t) {
   return ::strtoll(__nptr, __endptr, __base);
 }
 
+inline _LIBCPP_HIDE_FROM_ABI_C unsigned long
+strtoul_l(const char* __nptr, char** __endptr, int __base, locale_t) {
+  return ::strtoul(__nptr, __endptr, __base);
+}
+
 inline _LIBCPP_HIDE_FROM_ABI_C unsigned long long
 strtoull_l(const char* __nptr, char** __endptr, int __base, locale_t) {
   return ::strtoull(__nptr, __endptr, __base);
 }
 
 inline _LIBCPP_HIDE_FROM_ABI_C long long wcstoll_l(const wchar_t* __nptr, wchar_t** __endptr, int __base, locale_t) {
   return ::wcstoll(__nptr, __endptr, __base);
 }

libcxx/include/__support/openbsd/xlocale.h

 #define _LIBCPP___SUPPORT_OPENBSD_XLOCALE_H
 
 #include <__support/xlocale/__strtonum_fallback.h>
 #include <clocale>
 #include <cstdlib>
 #include <ctype.h>
 #include <cwctype>
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-inline _LIBCPP_HIDE_FROM_ABI_C long strtol_l(const char* __nptr, char** __endptr, int __base, locale_t) {
-  return ::strtol(__nptr, __endptr, __base);
-}
-
-inline _LIBCPP_HIDE_FROM_ABI_C unsigned long strtoul_l(const char* __nptr, char** __endptr, int __base, locale_t) {
-  return ::strtoul(__nptr, __endptr, __base);
-}
-
-#ifdef __cplusplus
-}
-#endif
-
 #endif

libcxx/include/__support/win32/locale_win32.h

                      size_t __nwc, size_t __len, mbstate_t *__restrict __ps, locale_t __loc);
 wint_t btowc_l( int __c, locale_t __loc );
 int wctob_l( wint_t __c, locale_t __loc );
 
 decltype(MB_CUR_MAX) MB_CUR_MAX_L( locale_t __l );
 
 // the *_l functions are prefixed on Windows, only available for msvcr80+, VS2005+
 #define mbtowc_l _mbtowc_l
+#define strtol_l _strtol_l
 #define strtoll_l _strtoi64_l
+#define strtoul_l _strtoul_l
 #define strtoull_l _strtoui64_l
 #define strtod_l _strtod_l
 #if defined(_LIBCPP_MSVCRT)
 #define strtof_l _strtof_l
 #define strtold_l _strtold_l
 #else
 _LIBCPP_FUNC_VIS float strtof_l(const char*, char**, locale_t);
 _LIBCPP_FUNC_VIS long double strtold_l(const char*, char**, locale_t);

libcxx/include/__support/xlocale/__strtonum_fallback.h

 inline _LIBCPP_HIDE_FROM_ABI_C double strtod_l(const char* __nptr, char** __endptr, locale_t) {
   return ::strtod(__nptr, __endptr);
 }
 
 inline _LIBCPP_HIDE_FROM_ABI_C long double strtold_l(const char* __nptr, char** __endptr, locale_t) {
   return ::strtold(__nptr, __endptr);
 }
 
+inline _LIBCPP_HIDE_FROM_ABI_C long strtol_l(const char* __nptr, char** __endptr, int __base, locale_t) {
+  return ::strtol(__nptr, __endptr, __base);
+}
+
 inline _LIBCPP_HIDE_FROM_ABI_C long long strtoll_l(const char* __nptr, char** __endptr, int __base, locale_t) {
   return ::strtoll(__nptr, __endptr, __base);
 }
 
+inline _LIBCPP_HIDE_FROM_ABI_C unsigned long
+strtoul_l(const char* __nptr, char** __endptr, int __base, locale_t) {
+  return ::strtoul(__nptr, __endptr, __base);
+}
+
 inline _LIBCPP_HIDE_FROM_ABI_C unsigned long long
 strtoull_l(const char* __nptr, char** __endptr, int __base, locale_t) {
   return ::strtoull(__nptr, __endptr, __base);
 }
 
 #ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
 inline _LIBCPP_HIDE_FROM_ABI_C long long wcstoll_l(const wchar_t* __nptr, wchar_t** __endptr, int __base, locale_t) {
   return ::wcstoll(__nptr, __endptr, __base);