Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG51131edf83e4: [libc++][PSTL] Implement std::replace{,_if,_copy,_copy_if}
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
libcxx/include/CMakeLists.txt | ||
---|---|---|
83 | Can we remove any old PSTL code with this patch? | |
libcxx/test/std/algorithms/alg.modifying.operations/alg.replace/pstl.replace.pass.cpp | ||
30 | There needs to be a test with a non-empty range but no match. Here and everywhere. | |
31 | Needs a test where you "match" more than one element in the range. For example std::array a = {1, 2, 3, 4, 3, 3, 5, 6, 3}; // then replace 3 by 9, you need to end up with {1, 2, 9, 4, 9, 9, 5, 6, 9} This comment applies to all the other algorithms as well. |
Can we remove any old PSTL code with this patch?