This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Update CMake linker flags to use large glink code
ClosedPublic

Authored by azhan92 on May 30 2023, 10:06 AM.

Details

Summary

Building clang/llvm as a debug build results in TOC overflow even when using large code model on AIX. This review updates the llvm/cmake/modules/HandleLLVMOptions.cmake file to use large glink code in addition to building as a large code model.

Diff Detail

Event Timeline

azhan92 created this revision.May 30 2023, 10:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 10:06 AM
azhan92 requested review of this revision.May 30 2023, 10:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 10:06 AM
azhan92 edited the summary of this revision. (Show Details)May 30 2023, 10:14 AM
azhan92 added a reviewer: daltenty.
daltenty edited the summary of this revision. (Show Details)May 30 2023, 10:25 AM
daltenty retitled this revision from [AIX] Update CMake linker flags to allow clang/llvm debug build. to [AIX] Update CMake linker flags to use large glink code.
daltenty added inline comments.
llvm/cmake/modules/HandleLLVMOptions.cmake
215

Is this missing a dash?

azhan92 added inline comments.May 30 2023, 10:31 AM
llvm/cmake/modules/HandleLLVMOptions.cmake
215

You're right, let me add that back.

azhan92 updated this revision to Diff 526707.May 30 2023, 10:32 AM
azhan92 edited the summary of this revision. (Show Details)

Correct options.

daltenty accepted this revision.Jun 6 2023, 6:45 AM

LGTM, with minor nit

llvm/cmake/modules/HandleLLVMOptions.cmake
215

nit: you should remove the space here

This revision is now accepted and ready to land.Jun 6 2023, 6:45 AM
azhan92 updated this revision to Diff 528846.Jun 6 2023, 7:04 AM

Delete space.

This revision was automatically updated to reflect the committed changes.