Allow variable names to be quoted with -var-list-children

[ChuckR]

Summary

allow '-var-list-children var0' and -var-list-children "var0"' to be used with the -var-list-children command. GDB MI allows for this and it is necessary if the variable name contains spaces, such as var5.std::_Vector_base<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >.

[ki.stfu]

lgtm

[ChuckR]

Thanks! Can you or somebody with commit access check this in for me?

[ChuckR]

Can you check this in for me?

[zturner]

Yea, I can. Do you not have commit access? You should email Chris Lattner and request it, turnaround time is pretty quick.

[ChuckR]

I requested it, thanks for the heads up!

[ChuckR]

@zturner I have been granted commit after approval from Chris. How do I commit from here?

[zturner]

You'll probably want to read this:
http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn

Try a test commit first (fix a typo or add a comment). If you have
specific problems with the test commit them post back and I can try to help.

[ChuckR]

@zturner I successfully submitted my test commit from an svn working copy. My former workflow was to use the read only git mirror, generate a diff, and submit it through this tool. Is there a better way to use differential so that I can submit directly via an approved code review?

[zturner]

You can't submit directly from a code review. You always have to submit via git svn dcommit. If you edit your commit message (e.g. with git commit --amend) you can add a line at the bottom that says

Differential Revision: http://reviews.llvm.org/D15168

Then when you dcommit it, Phabricator should automatically close the revision for you. But there's no way to submit from Phabricator.

[ChuckR]

Ok, thanks.

packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py

         self.expect("\^done,status=\"editable\"")
         self.runCmd("-var-list-children var2")
         self.expect("\^done,numchild=\"0\",has_more=\"0\"")
+        # Ensure -var-list-children also works with quotes
+        self.runCmd("-var-list-children \"var2\"")
+        self.expect("\^done,numchild=\"0\",has_more=\"0\"")
         self.runCmd("-data-evaluate-expression \"g_MyVar=30\"")
         self.expect("\^done,value=\"30\"")
         self.runCmd("-var-update --all-values var2")

tools/lldb-mi/MICmdCmdVar.cpp

 CMICmdCmdVarListChildren::ParseArgs()
 {
     m_setCmdArgs.Add(new CMICmdArgValPrintValues(m_constStrArgPrintValues, false, true));
-    m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgName, true, true));
+    m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgName, true, true, true));
     m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgFrom, false, true));
     m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgTo, false, true));
     return ParseValidateCmdOptions();