This is an archive of the discontinued LLVM Phabricator instance.

[clang][DeclPrinter] Fix AST print of out-of-line record definitions
ClosedPublic

Authored by strimo378 on May 25 2023, 7:40 PM.

Details

Summary

DeclPrinter::VisitCXXRecordDecl did not output qualifiers for records. As result, the output of out-of-line record definitions was incorrect. Please take a look at the provided test case...

Diff Detail

Event Timeline

strimo378 created this revision.May 25 2023, 7:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 7:40 PM
strimo378 requested review of this revision.May 25 2023, 7:40 PM
strimo378 set the repository for this revision to rG LLVM Github Monorepo.May 25 2023, 11:10 PM
strimo378 added a subscriber: cfe-commits.
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 11:10 PM
aaron.ballman accepted this revision.Jun 6 2023, 11:02 AM

LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like used for patch attribution?

This revision is now accepted and ready to land.Jun 6 2023, 11:02 AM

Please use "Timo Stripf" and timo.stripf@emmtrix.com

Thank you for your review.

This revision was landed with ongoing or failed builds.Jun 7 2023, 7:58 AM
This revision was automatically updated to reflect the committed changes.