This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Add additional test case for modules issue in Objective-C++
ClosedPublic

Authored by ldionne on May 25 2023, 9:46 AM.

Diff Detail

Event Timeline

ldionne created this revision.May 25 2023, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 9:46 AM
ldionne requested review of this revision.May 25 2023, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 9:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik added inline comments.
libcxx/test/libcxx/containers/sequences/vector/erase.modules.compile.pass.mm
13

Is this not implicitly checked through .pass.mm?

ldionne marked an inline comment as done.May 26 2023, 12:38 PM
ldionne added inline comments.
libcxx/test/libcxx/containers/sequences/vector/erase.modules.compile.pass.mm
13

No, it's not. I thought it was better to have it explicitly.

ldionne accepted this revision.May 26 2023, 12:39 PM
ldionne marked an inline comment as done.
This revision is now accepted and ready to land.May 26 2023, 12:39 PM
This revision was landed with ongoing or failed builds.May 26 2023, 12:40 PM
This revision was automatically updated to reflect the committed changes.