This is an archive of the discontinued LLVM Phabricator instance.

[clang][NFC] Prepare C++ DR suite for better test isolation
AcceptedPublic

Authored by Endill on May 25 2023, 4:33 AM.

Details

Reviewers
aaron.ballman
Group Reviewers
Restricted Project
Summary

This patch mechanically modifies existing DR status notation to incorporate //--- notation used by split-file utility.

This is a part of a bigger transition. Example could be seen in [[ a diff: https://gist.github.com/Endilll/1d8035d42bdf0dc73eaaf8a8c343bf8c/revisions. The idea is to split drNxx.cpp files into bunch of small files before feeding them into compiler. This would prevent cases like [[ https://godbolt.org/z/Pd88e1dr9 | this one ]], which is a reduced example of what I encountered while working on D148433.

I go into more details in the related Discourse thread.

Diff Detail

Event Timeline

Endill created this revision.May 25 2023, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 4:33 AM
Endill requested review of this revision.May 25 2023, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 4:33 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.May 25 2023, 4:49 AM

The changes LGTM (verified off-list that the regenerated HTML is identical before and after this change), but let's not land this until we've gotten farther along the review process with the related changes to split-file and the diagnostic verifier (just in case those reviews cause us to change direction for some reason).

This revision is now accepted and ready to land.May 25 2023, 4:49 AM

The changes LGTM (verified off-list that the regenerated HTML is identical before and after this change),

I've run make_cxx_dr_status on top of this patch, and learned that the patch didn't change anything in cxx_dr_status.html, and that it has been written resilient enough to happily digest the new notation of status comments.

but let's not land this until we've gotten farther along the review process with the related changes to split-file and the diagnostic verifier (just in case those reviews cause us to change direction for some reason).

I don't mind being cautious here. Even though initial feedback on every of them doesn't seem to reject the direction we've been pushing towards. Here are the patches we're waiting for:

Endill retitled this revision from [Clang][NFC] Prepare C++ DR suite for better test isolation to [clang][NFC] Prepare C++ DR suite for better test isolation.May 30 2023, 5:31 AM