This is an archive of the discontinued LLVM Phabricator instance.

Differential D151291

[libc] Make hermetic test depend on the unit test if it exists.
ClosedPublic

Authored by sivachandra on May 23 2023, 10:33 PM.

Details

Reviewers
jhuber6
Commits
rG99a493e3e3ee: [libc] Make hermetic test depend on the unit test if it exists.
Summary

We want to do this so that build system like ninja don't end up running
the hermetic and unit tests in parallel. Running in parallel can cause
problems for tests which read/write disk files as the hermetic and unit
tests can end up stepping on each other.

Diff Detail

Event Timeline

sivachandra created this revision.May 23 2023, 10:33 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 23 2023, 10:33 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.May 23 2023, 10:33 PM
Harbormaster completed remote builds in B234078: Diff 525007.May 23 2023, 10:38 PM
jhuber6 accepted this revision.May 24 2023, 4:39 AM

LG

This revision is now accepted and ready to land.May 24 2023, 4:39 AM
Closed by commit rG99a493e3e3ee: [libc] Make hermetic test depend on the unit test if it exists. (authored by sivachandra). · Explain WhyMay 24 2023, 11:27 PM
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rG99a493e3e3ee: [libc] Make hermetic test depend on the unit test if it exists..

Revision Contents

PathSize
libc/
cmake/
modules/
7 lines

Diff 525453

libc/cmake/modules/LLVMLibCTestRules.cmake

Show First 20 Lines • Show All 734 Lines • ▼ Show 20 Lines cmake_parse_arguments(
"" # Multi-value arguments "" # Multi-value arguments
${ARGN} ${ARGN}
) )
if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY) if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY)
add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS}) add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
endif() endif()
if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY) if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY)
add_libc_hermetic_test(${test_name}.__hermetic__ ${LIBC_TEST_UNPARSED_ARGUMENTS}) add_libc_hermetic_test(${test_name}.__hermetic__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
get_fq_target_name(${test_name} fq_test_name)
if(TARGET ${fq_test_name}.__unit__)
# Tests like the file tests perform file operations on disk file. If we
# don't chain up the unit test and hermetic test, then those tests will
# step on each other's files.
add_dependencies(${fq_test_name}.__hermetic__ ${fq_test_name}.__unit__)
endif()
endif() endif()
endfunction(add_libc_test) endfunction(add_libc_test)