This is an archive of the discontinued LLVM Phabricator instance.

Differential D151066

[tools] Add explicit check for plugin-api.h
Needs ReviewPublic

Authored by dmantipov on May 22 2023, 1:40 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

When using regular (host) build environments (on RedHat and
alikes at least), LLVM_BINUTILS_INCDIR usually expands to
/usr/include, which is always present. Since plugin-api.h
comes from separate binutils-devel package, an absence of
the latter causes compilation error, which can be avoided
by adding explicit check for plugin-api.h.

Diff Detail

Event Timeline

dmantipov created this revision.May 22 2023, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2023, 1:40 AM
dmantipov requested review of this revision.May 22 2023, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2023, 1:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B233498: Diff 524194.May 22 2023, 2:12 AM

Revision Contents

PathSize
llvm/
tools/
gold/
6 lines

Diff 524194

llvm/tools/gold/CMakeLists.txt

Context not available.
if( LLVM_ENABLE_PIC AND LLVM_BINUTILS_INCDIR ) if( LLVM_ENABLE_PIC AND LLVM_BINUTILS_INCDIR )
include_directories( ${LLVM_BINUTILS_INCDIR} ) include_directories( ${LLVM_BINUTILS_INCDIR} )
find_path(PLUGIN_API_H plugin-api.h ${LLVM_BINUTILS_INCDIR})
if (NOT PLUGIN_API_H)
message(FATAL_ERROR "Can't find plugin-api.h in ${LLVM_BINUTILS_INCDIR}. "
"Make sure you have GNU binutils header files installed there.")
endif()
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Linker Linker
Context not available.