This is an archive of the discontinued LLVM Phabricator instance.

Differential D150898

[libc] Disable newly added test from running on NVPTX
ClosedPublic

Authored by jhuber6 on May 18 2023, 12:04 PM.

Details

Reviewers
None
Commits
rG3ac8b647c7dc: [libc] Disable newly added test from running on NVPTX
Summary

A recent patch enabled this test which turns out to segfault on the
NVPTX architecture. We disable it for now.

Diff Detail

Event Timeline

jhuber6 created this revision.May 18 2023, 12:04 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 18 2023, 12:04 PM
Herald added subscribers: libc-commits, mattd, gchakrabarti and 3 others. · View Herald Transcript
jhuber6 requested review of this revision.May 18 2023, 12:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 18 2023, 12:05 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG3ac8b647c7dc: [libc] Disable newly added test from running on NVPTX (authored by jhuber6). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rG3ac8b647c7dc: [libc] Disable newly added test from running on NVPTX.
Harbormaster completed remote builds in B232964: Diff 523494.May 18 2023, 12:28 PM

Revision Contents

PathSize
libc/
test/
src/
__support/
3 lines

Diff 523494

libc/test/src/__support/CMakeLists.txt

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linesadd_libc_test(
SUITE SUITE
libc-support-tests libc-support-tests
SRCS SRCS
fixedvector_test.cpp fixedvector_test.cpp
DEPENDS DEPENDS
libc.src.__support.fixedvector libc.src.__support.fixedvector
) )
# This test fails with a segmentation fault on NVPTX.
if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
add_libc_test( add_libc_test(
char_vector_test char_vector_test
# This test relies on 'realloc' which is not implemented for hermetic tests. # This test relies on 'realloc' which is not implemented for hermetic tests.
UNIT_TEST_ONLY UNIT_TEST_ONLY
SUITE SUITE
libc-support-tests libc-support-tests
SRCS SRCS
char_vector_test.cpp char_vector_test.cpp
DEPENDS DEPENDS
libc.src.__support.char_vector libc.src.__support.char_vector
) )
endif()
add_executable( add_executable(
libc_str_to_float_comparison_test libc_str_to_float_comparison_test
str_to_float_comparison_test.cpp str_to_float_comparison_test.cpp
) )
target_link_libraries(libc_str_to_float_comparison_test target_link_libraries(libc_str_to_float_comparison_test
PRIVATE PRIVATE
Show All 21 Lines