This is an archive of the discontinued LLVM Phabricator instance.

[clang] Convert several tests to opaque pointers
ClosedPublic

Authored by barannikov88 on May 17 2023, 4:12 PM.

Diff Detail

Event Timeline

barannikov88 created this revision.May 17 2023, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 4:12 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
barannikov88 requested review of this revision.May 17 2023, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 4:12 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

These did require some intellectual work. I've noted changes that might be worth noticing.

clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp
22

This looks suspicious to me. The first gep index has i32 type (used to be i64). The two other geps have it i64.

clang/test/CodeGenCXX/address-space-cast-coerce.cpp
50

There is only one addrspacecast in this function. The second one matches a line in the other function.
I believe this is not intended. The review was iterative, I think they just forgot to update the test.

clang/test/CodeGenCXX/aix-alignment.cpp
22

Since bitcasts disappeared, added this load as an anchor.

clang/test/CodeGenCXX/attr-musttail.cpp
60

This test relies on exact value numbering. I didn't try to go smart about it and just updated the numbers.

nikic accepted this revision.May 18 2023, 6:33 AM

LGTM

clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp
22

This is okay -- it's an artifact of using a DL-unaware constant folder in Clang CodeGen. Index types will get canonicalized once a DL-aware folder sees them.

This revision is now accepted and ready to land.May 18 2023, 6:33 AM
This revision was automatically updated to reflect the committed changes.