Details
- Reviewers
nikic - Commits
- rG0bf5f632ed53: [clang] Convert several tests to opaque pointers
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
These did require some intellectual work. I've noted changes that might be worth noticing.
clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp | ||
---|---|---|
22 | This looks suspicious to me. The first gep index has i32 type (used to be i64). The two other geps have it i64. | |
clang/test/CodeGenCXX/address-space-cast-coerce.cpp | ||
50 | There is only one addrspacecast in this function. The second one matches a line in the other function. | |
clang/test/CodeGenCXX/aix-alignment.cpp | ||
22 | Since bitcasts disappeared, added this load as an anchor. | |
clang/test/CodeGenCXX/attr-musttail.cpp | ||
60 | This test relies on exact value numbering. I didn't try to go smart about it and just updated the numbers. |
LGTM
clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp | ||
---|---|---|
22 | This is okay -- it's an artifact of using a DL-unaware constant folder in Clang CodeGen. Index types will get canonicalized once a DL-aware folder sees them. |
This looks suspicious to me. The first gep index has i32 type (used to be i64). The two other geps have it i64.