This is an archive of the discontinued LLVM Phabricator instance.

Make sure the "Relevant Frame" gets selected before the initial stop printing
ClosedPublic

Authored by jingham on May 10 2023, 3:11 PM.

Details

Summary
When the Debugger runs HandleProcessEvent it should allow
selecting the "Most relevant" frame.

If you don't do that, then the correct frame gets selected, but it
happens AFTER the frame info gets printed in the stop message, so
you don't see the selected frame.

The test for this hid the issue because it ran `frame info` and
checked the result of that.  That happens after the recognizer selects
the frame, and so it was right.  But if the recognizer is working
correctly it will have already done the same printing in the stop
message, and this way we also verify that the stop message was right.

Diff Detail

Event Timeline

jingham created this revision.May 10 2023, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2023, 3:11 PM
jingham requested review of this revision.May 10 2023, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2023, 3:11 PM
mib accepted this revision.May 10 2023, 3:29 PM

LGTM!

This revision is now accepted and ready to land.May 10 2023, 3:29 PM
This revision was automatically updated to reflect the committed changes.