This change contains three util classes that were out from D145183 to make incremental progress
- automic_unique_lock
- intrusive_list
- intrusive_shared_ptr
Paths
| Differential D150205
[libc++] Utilities for implementing stop_token ClosedPublic Authored by huixie90 on May 9 2023, 8:51 AM.
Details
Summary This change contains three util classes that were out from D145183 to make incremental progress
Diff Detail
Unit TestsFailed Event TimelineComment Actions I really like this! Thanks a lot for splitting this into another review, I think this makes the stop_token code much easier to understand. LGTM with some comments.
This revision is now accepted and ready to land.May 12 2023, 8:59 AM Closed by commit rG544e38ca439f: [libc++] Utilities for implementing stop_token (authored by Hui). · Explain WhyMay 16 2023, 11:22 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 521730 libcxx/include/CMakeLists.txt
libcxx/include/__stop_token/atomic_unique_lock.h
libcxx/include/__stop_token/intrusive_list_view.h
libcxx/include/__stop_token/intrusive_shared_ptr.h
libcxx/include/libcxx.imp
libcxx/include/module.modulemap.in
libcxx/test/libcxx/private_headers.verify.cpp
libcxx/test/libcxx/thread/thread.stoptoken/atomic_unique_lock.pass.cpp
libcxx/test/libcxx/thread/thread.stoptoken/intrusive_list_view.pass.cpp
libcxx/test/libcxx/thread/thread.stoptoken/intrusive_shared_ptr.pass.cpp
|
Nit: let's use a c++ style comment