This is an archive of the discontinued LLVM Phabricator instance.

Differential D150201

[libcxx] Fix pstl __init_ identifier after 9c4717a
ClosedPublic

Authored by aaronmondal on May 9 2023, 7:31 AM.

Details

Reviewers
philnik
ldionne
Group Reviewers
Restricted Project
Commits
rG059986328c24: [libcxx] Fix pstl __init_ identifier after 9c4717a

Diff Detail

Event Timeline

aaronmondal created this revision.May 9 2023, 7:31 AM
Herald added a reviewer: ldionne. · View Herald TranscriptMay 9 2023, 7:32 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: miyuki. · View Herald Transcript
aaronmondal requested review of this revision.May 9 2023, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2023, 7:32 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
aaronmondal mentioned this in D149787: [libc++][PSTL][NFC] Fix the naming in the SIMD backend.May 9 2023, 7:33 AM
Harbormaster completed remote builds in B230868: Diff 520696.May 9 2023, 11:13 AM
ldionne accepted this revision.May 10 2023, 9:15 AM
This revision is now accepted and ready to land.May 10 2023, 9:15 AM
Closed by commit rG059986328c24: [libcxx] Fix pstl __init_ identifier after 9c4717a (authored by aaronmondal). · Explain WhyMay 10 2023, 10:21 AM
This revision was automatically updated to reflect the committed changes.
aaronmondal added a commit: rG059986328c24: [libcxx] Fix pstl __init_ identifier after 9c4717a.

Revision Contents

PathSize
libcxx/
include/
__pstl/
internal/
8 lines

Diff 521029

libcxx/include/__pstl/internal/unseq_backend_simd.h

Show First 20 Lines • Show All 507 Lines • ▼ Show 20 Lines
typename std::enable_if<!is_arithmetic_plus<_Tp, _BinaryOperation>::value, std::pair<_OutputIterator, _Tp>>::type typename std::enable_if<!is_arithmetic_plus<_Tp, _BinaryOperation>::value, std::pair<_OutputIterator, _Tp>>::type
__simd_scan(_InputIterator __first, _Size __n, _OutputIterator __result, _UnaryOperation __unary_op, _Tp __init, __simd_scan(_InputIterator __first, _Size __n, _OutputIterator __result, _UnaryOperation __unary_op, _Tp __init,
_BinaryOperation __binary_op, /*Inclusive*/ std::false_type) _BinaryOperation __binary_op, /*Inclusive*/ std::false_type)
{ {
typedef _Combiner<_Tp, _BinaryOperation> _CombinerType; typedef _Combiner<_Tp, _BinaryOperation> _CombinerType;
_CombinerType __combined_init{__init, &__binary_op}; _CombinerType __combined_init{__init, &__binary_op};
_PSTL_PRAGMA_DECLARE_REDUCTION(__bin_op, _CombinerType) _PSTL_PRAGMA_DECLARE_REDUCTION(__bin_op, _CombinerType)
_PSTL_PRAGMA_SIMD_SCAN(__bin_op : __init_) _PSTL_PRAGMA_SIMD_SCAN(__bin_op : __combined_init)
for (_Size __i = 0; __i < __n; ++__i) for (_Size __i = 0; __i < __n; ++__i)
{ {
__result[__i] = __combined_init.__value_; __result[__i] = __combined_init.__value_;
_PSTL_PRAGMA_SIMD_EXCLUSIVE_SCAN(__init_) _PSTL_PRAGMA_SIMD_EXCLUSIVE_SCAN(__combined_init)
__combined_init.__value_ = __binary_op(__combined_init.__value_, __unary_op(__first[__i])); __combined_init.__value_ = __binary_op(__combined_init.__value_, __unary_op(__first[__i]));
} }
return std::make_pair(__result + __n, __combined_init.__value_); return std::make_pair(__result + __n, __combined_init.__value_);
} }
// Inclusive scan for "+" and arithmetic types // Inclusive scan for "+" and arithmetic types
template <class _InputIterator, class _Size, class _OutputIterator, class _UnaryOperation, class _Tp, template <class _InputIterator, class _Size, class _OutputIterator, class _UnaryOperation, class _Tp,
class _BinaryOperation> class _BinaryOperation>
Show All 19 Lines
typename std::enable_if<!is_arithmetic_plus<_Tp, _BinaryOperation>::value, std::pair<_OutputIterator, _Tp>>::type typename std::enable_if<!is_arithmetic_plus<_Tp, _BinaryOperation>::value, std::pair<_OutputIterator, _Tp>>::type
__simd_scan(_InputIterator __first, _Size __n, _OutputIterator __result, _UnaryOperation __unary_op, _Tp __init, __simd_scan(_InputIterator __first, _Size __n, _OutputIterator __result, _UnaryOperation __unary_op, _Tp __init,
_BinaryOperation __binary_op, std::true_type) _BinaryOperation __binary_op, std::true_type)
{ {
typedef _Combiner<_Tp, _BinaryOperation> _CombinerType; typedef _Combiner<_Tp, _BinaryOperation> _CombinerType;
_CombinerType __combined_init{__init, &__binary_op}; _CombinerType __combined_init{__init, &__binary_op};
_PSTL_PRAGMA_DECLARE_REDUCTION(__bin_op, _CombinerType) _PSTL_PRAGMA_DECLARE_REDUCTION(__bin_op, _CombinerType)
_PSTL_PRAGMA_SIMD_SCAN(__bin_op : __init_) _PSTL_PRAGMA_SIMD_SCAN(__bin_op : __combined_init)
for (_Size __i = 0; __i < __n; ++__i) for (_Size __i = 0; __i < __n; ++__i)
{ {
__combined_init.__value_ = __binary_op(__combined_init.__value_, __unary_op(__first[__i])); __combined_init.__value_ = __binary_op(__combined_init.__value_, __unary_op(__first[__i]));
_PSTL_PRAGMA_SIMD_INCLUSIVE_SCAN(__init_) _PSTL_PRAGMA_SIMD_INCLUSIVE_SCAN(__combined_init)
__result[__i] = __combined_init.__value_; __result[__i] = __combined_init.__value_;
} }
return std::make_pair(__result + __n, __combined_init.__value_); return std::make_pair(__result + __n, __combined_init.__value_);
} }
// [restriction] - std::iterator_traits<_ForwardIterator>::value_type should be DefaultConstructible. // [restriction] - std::iterator_traits<_ForwardIterator>::value_type should be DefaultConstructible.
// complexity [violation] - We will have at most (__n-1 + number_of_lanes) comparisons instead of at most __n-1. // complexity [violation] - We will have at most (__n-1 + number_of_lanes) comparisons instead of at most __n-1.
template <typename _ForwardIterator, typename _Size, typename _Compare> template <typename _ForwardIterator, typename _Size, typename _Compare>
▲ Show 20 Lines • Show All 248 Lines • Show Last 20 Lines