Like done D149543 this validates the other formatter specializations.
Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG62858636f54a: [NFC][libc++][format] Tests formatter requirements.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM w/ comments and CI.
libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp | ||
---|---|---|
19 | ||
27–30 | I think this comment does not apply to this test. | |
libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/types.compile.pass.cpp | ||
21–24 | ||
libcxx/test/std/utilities/format/types.compile.pass.cpp | ||
55–58 |
Comment Actions
The CI was green, updating the result on Phab was red. I've applied the fixes to the earlier committed vector<bool>::reference too.
libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp | ||
---|---|---|
27–30 | I've changed the wording slightly why we don't use the concept here. |