This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++][format] Tests formatter requirements.
ClosedPublic

Authored by Mordante on May 6 2023, 8:30 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG62858636f54a: [NFC][libc++][format] Tests formatter requirements.
Summary

Like done D149543 this validates the other formatter specializations.

Diff Detail

Event Timeline

Mordante created this revision.May 6 2023, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2023, 8:30 AM
Mordante updated this revision to Diff 520111.May 6 2023, 11:15 AM

CI fixes.

Mordante published this revision for review.May 7 2023, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 8:44 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 9 2023, 9:20 AM
ldionne added a subscriber: ldionne.

LGTM w/ comments and CI.

libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp
19
27–30

I think this comment does not apply to this test.

libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/types.compile.pass.cpp
21–24
libcxx/test/std/utilities/format/types.compile.pass.cpp
55–58
This revision is now accepted and ready to land.May 9 2023, 9:20 AM
Mordante marked 4 inline comments as done.May 13 2023, 2:20 AM

LGTM w/ comments and CI.

The CI was green, updating the result on Phab was red. I've applied the fixes to the earlier committed vector<bool>::reference too.

libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp
27–30

I've changed the wording slightly why we don't use the concept here.

This revision was landed with ongoing or failed builds.May 13 2023, 2:21 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.