This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add RPC utility functions for handling the lanes
AbandonedPublic

Authored by JonChesterfield on May 4 2023, 12:54 PM.

Details

Reviewers
jhuber6
Summary

Split this into separate patch. It provides utility function that let
us operate on the lanes.

Diff Detail

Event Timeline

jhuber6 created this revision.May 4 2023, 12:54 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 4 2023, 12:54 PM
jhuber6 requested review of this revision.May 4 2023, 12:54 PM
This revision is now accepted and ready to land.May 4 2023, 12:59 PM
JonChesterfield requested changes to this revision.May 4 2023, 12:59 PM

Actually no, sorry - too much stuff here

This revision now requires changes to proceed.May 4 2023, 12:59 PM
JonChesterfield added inline comments.May 4 2023, 1:00 PM
libc/src/__support/RPC/rpc_util.h
20

this ^ isn't a utility thing

39

this one ^ is really helpful for the locks thing I'm documenting

44

and this ^ might not survive refactoring in the parent patch

jhuber6 added inline comments.May 4 2023, 1:02 PM
libc/src/__support/RPC/rpc_util.h
44

I use it to not check the mask when we invoke the send / recv callback.

JonChesterfield commandeered this revision.May 4 2023, 1:04 PM
JonChesterfield edited reviewers, added: jhuber6; removed: JonChesterfield.

as req

This revision now requires review to proceed.May 4 2023, 1:04 PM
JonChesterfield abandoned this revision.May 4 2023, 1:04 PM