This is an archive of the discontinued LLVM Phabricator instance.

[fortran] Disable some gfortran tests that non-determinstically fail when testing in parallel
ClosedPublic

Authored by tarunprabhu on May 4 2023, 9:29 AM.

Details

Summary

Several gfortran tests read/write/delete the same file. When running the test suite in parallel, this results in non-deterministic test failures since the tests race on the file. This disables several tests that have such implicit race conditions.

A better approach would be to have the tests run in their own temporary directory, or to have lit run just those tests serially. I will look into those options and put up a patch. This is to quickly work around the non-deterministic failures in the buildbots such as (among several others):

https://lab.llvm.org/buildbot/#/builders/197/builds/4630
https://lab.llvm.org/buildbot/#/builders/197/builds/4640

Diff Detail

Repository
rT test-suite

Event Timeline

tarunprabhu created this revision.May 4 2023, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2023, 9:29 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
tarunprabhu requested review of this revision.May 4 2023, 9:29 AM

Approving since this fixes the buildbots.

This revision is now accepted and ready to land.May 4 2023, 10:58 AM