This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Update CMake documentation on using ccache
AbandonedPublic

Authored by aidengrossman on May 3 2023, 11:19 PM.

Details

Reviewers
thieta
Summary

Since LLVM's minimum CMake version has been bumped to an appropriate
version and CMake noe nwatively supports the
CMAKE_{C,CXX}_COMPILER_LAUNCHER flags, the LLVM_CCACHE_BUILD flag is now
deprecated. This patch adjusts the documentation to reflect this change.

https://discourse.llvm.org/t/llvm-ccache-build-is-deprecated/68431

Diff Detail

Event Timeline

aidengrossman created this revision.May 3 2023, 11:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 11:19 PM
aidengrossman requested review of this revision.May 3 2023, 11:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 11:19 PM

Thanks for the patch! In my other patch https://reviews.llvm.org/D143468 (which was reverted) - there was no clear consensus on removing this option. I think that discussion needs to be solved first before we push people to not use LLVM_CCACHE_BUILD.

aidengrossman abandoned this revision.May 12 2023, 10:45 PM

Ah. Makes sense. I see Alex Bradbury already made a similar suggestion your patch. I should've followed that more closely. Sorry for the noise.