This is an archive of the discontinued LLVM Phabricator instance.

[libc] Revert rounding mode changes for hermetic tests
ClosedPublic

Authored by jhuber6 on May 3 2023, 9:51 AM.

Details

Summary

We got rid of the rounding mode here so that the hermetic tests wouldn't
depend on the system fenv.h. But this seemed to cause some bots to
break. Getting rid of this change for now, it should be fine for the CPU
builds.

Diff Detail

Event Timeline

jhuber6 created this revision.May 3 2023, 9:51 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 3 2023, 9:51 AM
jhuber6 requested review of this revision.May 3 2023, 9:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2023, 9:51 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.