This is an archive of the discontinued LLVM Phabricator instance.

Differential D149649

Update comment.
Needs ReviewPublic

Authored by massberg on May 2 2023, 6:27 AM.

Details

Reviewers
ilya-biryukov
Summary

[class.rel] has been renamed to [class.compare.secondary].

Diff Detail

Event Timeline

massberg created this revision.May 2 2023, 6:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 6:27 AM
massberg requested review of this revision.May 2 2023, 6:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 6:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B229413: Diff 518700.May 2 2023, 10:38 AM

Revision Contents

PathSize
clang/
lib/
Sema/
2 lines

Diff 518700

clang/lib/Sema/SemaDeclCXX.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,700 Lines • ▼ Show 20 Lines if (llvm::none_of(RD->friends(), [&](const FriendDecl *F) {
})) { })) {
Diag(FD->getLocation(), diag::err_defaulted_comparison_not_friend) Diag(FD->getLocation(), diag::err_defaulted_comparison_not_friend)
<< int(DCK) << int(0) << RD; << int(DCK) << int(0) << RD;
Diag(RD->getCanonicalDecl()->getLocation(), diag::note_declared_at); Diag(RD->getCanonicalDecl()->getLocation(), diag::note_declared_at);
return true; return true;
} }
} }
// C++2a [class.eq]p1, [class.rel]p1: // C++2a [class.eq]p1, [class.compare.secondary]p1:
// A [defaulted comparison other than <=>] shall have a declared return // A [defaulted comparison other than <=>] shall have a declared return
// type bool. // type bool.
if (DCK != DefaultedComparisonKind::ThreeWay && if (DCK != DefaultedComparisonKind::ThreeWay &&
!FD->getDeclaredReturnType()->isDependentType() && !FD->getDeclaredReturnType()->isDependentType() &&
!Context.hasSameType(FD->getDeclaredReturnType(), Context.BoolTy)) { !Context.hasSameType(FD->getDeclaredReturnType(), Context.BoolTy)) {
Diag(FD->getLocation(), diag::err_defaulted_comparison_return_type_not_bool) Diag(FD->getLocation(), diag::err_defaulted_comparison_return_type_not_bool)
<< (int)DCK << FD->getDeclaredReturnType() << Context.BoolTy << (int)DCK << FD->getDeclaredReturnType() << Context.BoolTy
<< FD->getReturnTypeSourceRange(); << FD->getReturnTypeSourceRange();
▲ Show 20 Lines • Show All 9,913 Lines • Show Last 20 Lines