This is an archive of the discontinued LLVM Phabricator instance.

Differential D149609

Silence warning on MSVC after 5b2423183cb3
ClosedPublic

Authored by aganea on May 1 2023, 12:33 PM.

Details

Reviewers
Everybody0523
yusra.syeda
Commits
rG8efc7de0e639: [llvm][unittests] Silence warning on MSVC after 5b2423183cb3
Summary

This happens when building with latest MSVC 2022. We don't have any bots that run with this compiler.

Diff Detail

Event Timeline

aganea created this revision.May 1 2023, 12:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 12:33 PM
aganea requested review of this revision.May 1 2023, 12:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 12:33 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yusra.syeda accepted this revision.May 1 2023, 12:42 PM
This revision is now accepted and ready to land.May 1 2023, 12:42 PM
Harbormaster completed remote builds in B229297: Diff 518528.May 1 2023, 1:32 PM
Closed by commit rG8efc7de0e639: [llvm][unittests] Silence warning on MSVC after 5b2423183cb3 (authored by aganea). · Explain WhyMay 2 2023, 5:49 AM
This revision was automatically updated to reflect the committed changes.
aganea added a commit: rG8efc7de0e639: [llvm][unittests] Silence warning on MSVC after 5b2423183cb3.

Revision Contents

PathSize
llvm/
unittests/
Object/
5 lines

Diff 518692

llvm/unittests/Object/CMakeLists.txt

Show All 15 Linesadd_llvm_unittest(ObjectTests
ObjectFileTest.cpp ObjectFileTest.cpp
OffloadingTest.cpp OffloadingTest.cpp
SymbolSizeTest.cpp SymbolSizeTest.cpp
SymbolicFileTest.cpp SymbolicFileTest.cpp
XCOFFObjectFileTest.cpp XCOFFObjectFileTest.cpp
) )
target_link_libraries(ObjectTests PRIVATE LLVMTestingSupport) target_link_libraries(ObjectTests PRIVATE LLVMTestingSupport)
if (MSVC)
# Disable warning C4309: '=': truncation of constant value
set_source_files_properties(GOFFObjectFileTest.cpp PROPERTIES COMPILE_FLAGS -wd4309)
endif()