This is an archive of the discontinued LLVM Phabricator instance.

Differential D149371

[ValueTracking] Add tests for proving `fshr`/`fshl` is non-zero; NFC
ClosedPublic

Authored by goldstein.w.n on Apr 27 2023, 12:01 PM.

Details

Reviewers
nikic
spatel
majnemer
Commits
rG74157bf6e225: [ValueTracking] Add tests for proving `fshr`/`fshl` is non-zero; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 27 2023, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 12:01 PM
goldstein.w.n requested review of this revision.Apr 27 2023, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 12:01 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D149372: [ValueTracking] Add logic for `fshl/fshr(A, B, C) != 0` if `A == B && A ! = 0`.Apr 27 2023, 12:02 PM
goldstein.w.n added reviewers: nikic, spatel, majnemer.
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 27 2023, 12:02 PM
nikic accepted this revision.Apr 27 2023, 12:04 PM

LGTM

This revision is now accepted and ready to land.Apr 27 2023, 12:04 PM
This revision was landed with ongoing or failed builds.Apr 27 2023, 11:57 PM
Closed by commit rG74157bf6e225: [ValueTracking] Add tests for proving `fshr`/`fshl` is non-zero; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG74157bf6e225: [ValueTracking] Add tests for proving `fshr`/`fshl` is non-zero; NFC.

Revision Contents

PathSize
llvm/
test/
Analysis/
ValueTracking/
78 lines

Diff 517818

llvm/test/Analysis/ValueTracking/known-non-zero.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -passes=instsimplify < %s -S | FileCheck %s ; RUN: opt -passes=instsimplify < %s -S | FileCheck %s
declare void @llvm.assume(i1) declare void @llvm.assume(i1)
declare i8 @llvm.abs.i8(i8, i1) declare i8 @llvm.abs.i8(i8, i1)
declare i8 @llvm.bitreverse.i8(i8) declare i8 @llvm.bitreverse.i8(i8)
declare i16 @llvm.bswap.i16(i16) declare i16 @llvm.bswap.i16(i16)
declare i8 @llvm.ctpop.i8(i8) declare i8 @llvm.ctpop.i8(i8)
declare <2 x i8> @llvm.uadd.sat.2xi8(<2 x i8>, <2 x i8>) declare <2 x i8> @llvm.uadd.sat.2xi8(<2 x i8>, <2 x i8>)
declare i8 @llvm.uadd.sat.i8(i8, i8) declare i8 @llvm.uadd.sat.i8(i8, i8)
declare i8 @llvm.fshr.i8(i8, i8, i8)
declare i8 @llvm.fshl.i8(i8, i8, i8)
;; Throughout use: X > Y || Y == 0 which folds to X > Y iff X known ;; Throughout use: X > Y || Y == 0 which folds to X > Y iff X known
;; non-zero. Do this because many of the expressions already have ;; non-zero. Do this because many of the expressions already have
;; hardcoded cases for folding Foo(X) == 0 -> X == 0 and we want to ;; hardcoded cases for folding Foo(X) == 0 -> X == 0 and we want to
;; test explicitly that `isKnownNonZero` works. ;; test explicitly that `isKnownNonZero` works.
define i1 @check_neg(i8 %x, i8 %y) { define i1 @check_neg(i8 %x, i8 %y) {
; CHECK-LABEL: @check_neg( ; CHECK-LABEL: @check_neg(
▲ Show 20 Lines • Show All 501 Lines • ▼ Show 20 Lines
; ;
%x = or i8 %xx, 6 %x = or i8 %xx, 6
%y = and i8 %yy, 7 %y = and i8 %yy, 7
%d = udiv i8 %x, %y %d = udiv i8 %x, %y
%o = or i8 %d, %z %o = or i8 %d, %z
%r = icmp eq i8 %o, 0 %r = icmp eq i8 %o, 0
ret i1 %r ret i1 %r
} }
define i1 @fshr_non_zero(i8 %x, i8 %y, i8 %z) {
; CHECK-LABEL: @fshr_non_zero(
; CHECK-NEXT: [[PRED0:%.*]] = icmp ne i8 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[PRED0]])
; CHECK-NEXT: [[V:%.*]] = tail call i8 @llvm.fshr.i8(i8 [[X]], i8 [[X]], i8 [[Y:%.*]])
; CHECK-NEXT: [[OR:%.*]] = or i8 [[V]], [[Z:%.*]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[OR]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%pred0 = icmp ne i8 %x, 0
call void @llvm.assume(i1 %pred0)
%v = tail call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %y)
%or = or i8 %v, %z
%r = icmp eq i8 %or, 0
ret i1 %r
}
define i1 @fshr_non_zero_fail(i8 %x, i8 %y, i8 %z, i8 %w) {
; CHECK-LABEL: @fshr_non_zero_fail(
; CHECK-NEXT: [[PRED0:%.*]] = icmp ne i8 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[PRED0]])
; CHECK-NEXT: [[PRED1:%.*]] = icmp ne i8 [[W:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[PRED1]])
; CHECK-NEXT: [[V:%.*]] = tail call i8 @llvm.fshr.i8(i8 [[X]], i8 [[W]], i8 [[Y:%.*]])
; CHECK-NEXT: [[OR:%.*]] = or i8 [[V]], [[Z:%.*]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[OR]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%pred0 = icmp ne i8 %x, 0
call void @llvm.assume(i1 %pred0)
%pred1 = icmp ne i8 %w, 0
call void @llvm.assume(i1 %pred1)
%v = tail call i8 @llvm.fshr.i8(i8 %x, i8 %w, i8 %y)
%or = or i8 %v, %z
%r = icmp eq i8 %or, 0
ret i1 %r
}
define i1 @fshl_non_zero(i8 %x, i8 %y, i8 %z) {
; CHECK-LABEL: @fshl_non_zero(
; CHECK-NEXT: [[PRED0:%.*]] = icmp ne i8 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[PRED0]])
; CHECK-NEXT: [[V:%.*]] = tail call i8 @llvm.fshl.i8(i8 [[X]], i8 [[X]], i8 [[Y:%.*]])
; CHECK-NEXT: [[OR:%.*]] = or i8 [[V]], [[Z:%.*]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[OR]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%pred0 = icmp ne i8 %x, 0
call void @llvm.assume(i1 %pred0)
%v = tail call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 %y)
%or = or i8 %v, %z
%r = icmp eq i8 %or, 0
ret i1 %r
}
define i1 @fshl_non_zero_fail(i8 %x, i8 %y, i8 %z, i8 %w) {
; CHECK-LABEL: @fshl_non_zero_fail(
; CHECK-NEXT: [[PRED0:%.*]] = icmp ne i8 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[PRED0]])
; CHECK-NEXT: [[PRED1:%.*]] = icmp ne i8 [[W:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[PRED1]])
; CHECK-NEXT: [[V:%.*]] = tail call i8 @llvm.fshl.i8(i8 [[X]], i8 [[W]], i8 [[Y:%.*]])
; CHECK-NEXT: [[OR:%.*]] = or i8 [[V]], [[Z:%.*]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[OR]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%pred0 = icmp ne i8 %x, 0
call void @llvm.assume(i1 %pred0)
%pred1 = icmp ne i8 %w, 0
call void @llvm.assume(i1 %pred1)
%v = tail call i8 @llvm.fshl.i8(i8 %x, i8 %w, i8 %y)
%or = or i8 %v, %z
%r = icmp eq i8 %or, 0
ret i1 %r
}