This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Don't allocate memory if free space in segmented stack is just enough.
ClosedPublic

Authored by ZhiyaoMa98 on Apr 26 2023, 6:08 PM.

Details

Summary

Assuming that the stack grows downwards, it is fine if the stack pointer is exactly at the stacklet boundary. We should use less-or-equal condition when deciding whether to skip new memory allocation.

Diff Detail

Event Timeline

ZhiyaoMa98 created this revision.Apr 26 2023, 6:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 6:08 PM
ZhiyaoMa98 requested review of this revision.Apr 26 2023, 6:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 6:08 PM
This revision is now accepted and ready to land.Apr 28 2023, 3:52 AM

Thanks. Since I don't have push permission, I'd appreciate if you could help me make the commit.

Name: Zhiyao Ma
Email: zhiyao.ma.98@gmail.com

This revision was landed with ongoing or failed builds.May 2 2023, 5:10 AM
This revision was automatically updated to reflect the committed changes.