This is an archive of the discontinued LLVM Phabricator instance.

Differential D149274

[NFC][Clang]Remove a reference on argument since 'Name' is not modified'
ClosedPublic

Authored by mingmingl on Apr 26 2023, 10:55 AM.

Download Raw Diff

Details

Reviewers

nickdesaulniers

Commits

rG739f5578c497: [NFC][Clang]Remove a reference on argument since 'Name' is not modified'

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mingmingl created this revision.Apr 26 2023, 10:55 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 10:55 AM

mingmingl requested review of this revision.Apr 26 2023, 10:55 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 10:55 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

mingmingl retitled this revision from [NFC][Clang]Remove a e reference on argument since 'Name' is not modified' to [NFC][Clang]Remove a reference on argument since 'Name' is not modified'.Apr 26 2023, 11:15 AM

mingmingl added a reviewer: nickdesaulniers.

Thanks for the patch!

This revision is now accepted and ready to land.Apr 26 2023, 11:17 AM

thanks for the quick reviews!

This revision was landed with ongoing or failed builds.Apr 26 2023, 11:23 AM

Closed by commit rG739f5578c497: [NFC][Clang]Remove a reference on argument since 'Name' is not modified' (authored by mingmingl). · Explain Why

This revision was automatically updated to reflect the committed changes.

mingmingl added a commit: rG739f5578c497: [NFC][Clang]Remove a reference on argument since 'Name' is not modified'.

Harbormaster completed remote builds in B228340: Diff 517241.Apr 26 2023, 12:03 PM

Revision Contents

Path

Size

clang/

lib/

Basic/

Targets/

X86.cpp

2 lines

Diff 517252

clang/lib/Basic/Targets/X86.cpp

	Show First 20 Lines • Show All 1,207 Lines • ▼ Show 20 Lines
	#define X86_CPU_TYPE_ALIAS(ENUM, ALIAS) .Case(ALIAS, true)			#define X86_CPU_TYPE_ALIAS(ENUM, ALIAS) .Case(ALIAS, true)
	#define X86_CPU_TYPE(ENUM, STR) .Case(STR, true)			#define X86_CPU_TYPE(ENUM, STR) .Case(STR, true)
	#define X86_CPU_SUBTYPE_ALIAS(ENUM, ALIAS) .Case(ALIAS, true)			#define X86_CPU_SUBTYPE_ALIAS(ENUM, ALIAS) .Case(ALIAS, true)
	#define X86_CPU_SUBTYPE(ENUM, STR) .Case(STR, true)			#define X86_CPU_SUBTYPE(ENUM, STR) .Case(STR, true)
	#include "llvm/TargetParser/X86TargetParser.def"			#include "llvm/TargetParser/X86TargetParser.def"
	.Default(false);			.Default(false);
	}			}

	static unsigned matchAsmCCConstraint(const char *&Name) {			static unsigned matchAsmCCConstraint(const char *Name) {
	auto RV = llvm::StringSwitch<unsigned>(Name)			auto RV = llvm::StringSwitch<unsigned>(Name)
	.Case("@cca", 4)			.Case("@cca", 4)
	.Case("@ccae", 5)			.Case("@ccae", 5)
	.Case("@ccb", 4)			.Case("@ccb", 4)
	.Case("@ccbe", 5)			.Case("@ccbe", 5)
	.Case("@ccc", 4)			.Case("@ccc", 4)
	.Case("@cce", 4)			.Case("@cce", 4)
	.Case("@ccz", 4)			.Case("@ccz", 4)
	▲ Show 20 Lines • Show All 397 Lines • Show Last 20 Lines