This is an archive of the discontinued LLVM Phabricator instance.

Differential D149148

[Sema] Fix _Alignas/isCXX11Attribute() FIXME
ClosedPublic

Authored by rsandifo-arm on Apr 25 2023, 5:24 AM.

Details

Reviewers
erichkeane
aaron.ballman
Commits
rG5794ea421a0d: [Sema] Fix _Alignas/isCXX11Attribute() FIXME
Summary

When doing https://reviews.llvm.org/D148105 , I hadn't noticed that
there was also a FIXME about the misclassification of _Alignas in
ProcessDeclAttribute.

Diff Detail

Event Timeline

rsandifo-arm created this revision.Apr 25 2023, 5:24 AM
Herald added a reviewer: aaron.ballman. · View Herald TranscriptApr 25 2023, 5:24 AM
Herald added a project: Restricted Project. · View Herald Transcript
rsandifo-arm requested review of this revision.Apr 25 2023, 5:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 5:24 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
erichkeane accepted this revision.Apr 25 2023, 6:12 AM
This revision is now accepted and ready to land.Apr 25 2023, 6:12 AM
This revision was landed with ongoing or failed builds.Apr 26 2023, 1:50 AM
Closed by commit rG5794ea421a0d: [Sema] Fix _Alignas/isCXX11Attribute() FIXME (authored by rsandifo-arm). · Explain Why
This revision was automatically updated to reflect the committed changes.
rsandifo-arm added a commit: rG5794ea421a0d: [Sema] Fix _Alignas/isCXX11Attribute() FIXME.

Revision Contents

PathSize
clang/
lib/
Sema/
8 lines

Diff 517097

clang/lib/Sema/SemaDeclAttr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,585 Lines • ▼ Show 20 Lines
static void static void
ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D, const ParsedAttr &AL, ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D, const ParsedAttr &AL,
const Sema::ProcessDeclAttributeOptions &Options) { const Sema::ProcessDeclAttributeOptions &Options) {
if (AL.isInvalid() || AL.getKind() == ParsedAttr::IgnoredAttribute) if (AL.isInvalid() || AL.getKind() == ParsedAttr::IgnoredAttribute)
return; return;
// Ignore C++11 attributes on declarator chunks: they appertain to the type // Ignore C++11 attributes on declarator chunks: they appertain to the type
// instead. // instead.
// FIXME: We currently check the attribute syntax directly instead of using if (AL.isCXX11Attribute() && !Options.IncludeCXX11Attributes)
// isCXX11Attribute(), which currently erroneously classifies the C11
// `_Alignas` attribute as a C++11 attribute. `_Alignas` can appear on the
// `DeclSpec`, so we need to let it through here to make sure it is processed
// appropriately. Once the behavior of isCXX11Attribute() is fixed, we can
// go back to using that here.
if (AL.getSyntax() == ParsedAttr::AS_CXX11 && !Options.IncludeCXX11Attributes)
return; return;
// Unknown attributes are automatically warned on. Target-specific attributes // Unknown attributes are automatically warned on. Target-specific attributes
// which do not apply to the current target architecture are treated as // which do not apply to the current target architecture are treated as
// though they were unknown attributes. // though they were unknown attributes.
if (AL.getKind() == ParsedAttr::UnknownAttribute || if (AL.getKind() == ParsedAttr::UnknownAttribute ||
!AL.existsInTarget(S.Context.getTargetInfo())) { !AL.existsInTarget(S.Context.getTargetInfo())) {
S.Diag(AL.getLoc(), S.Diag(AL.getLoc(),
▲ Show 20 Lines • Show All 1,169 Lines • Show Last 20 Lines