This is an archive of the discontinued LLVM Phabricator instance.

Differential D149105

[libc][Obvious] Enable hermetic tests only under full build.
ClosedPublic

Authored by sivachandra on Apr 24 2023, 4:08 PM.

Download Raw Diff

Details

Reviewers

jhuber6

Commits

rG7b37f732783e: [libc][Obvious] Enable hermetic tests only under full build.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

sivachandra created this revision.Apr 24 2023, 4:08 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 24 2023, 4:08 PM

Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript

sivachandra requested review of this revision.Apr 24 2023, 4:08 PM

jhuber6 accepted this revision.Apr 24 2023, 4:09 PM

jhuber6 added inline comments.

libc/CMakeLists.txt
80	Not really important, but does this work?

This revision is now accepted and ready to land.Apr 24 2023, 4:09 PM

Harbormaster completed remote builds in B227841: Diff 516565.Apr 24 2023, 4:15 PM

Modify according to the suggestion.

jhuber6 accepted this revision.Apr 24 2023, 4:21 PM

This revision was landed with ongoing or failed builds.Apr 24 2023, 4:22 PM

Closed by commit rG7b37f732783e: [libc][Obvious] Enable hermetic tests only under full build. (authored by sivachandra). · Explain Why

This revision was automatically updated to reflect the committed changes.

sivachandra added a commit: rG7b37f732783e: [libc][Obvious] Enable hermetic tests only under full build..

Revision Contents

Path

Size

libc/

CMakeLists.txt

2 lines

Diff 516572

libc/CMakeLists.txt

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines

option(LLVM_LIBC_FULL_BUILD "Build and test LLVM libc as if it is the full libc" OFF)

option(LLVM_LIBC_IMPLEMENTATION_DEFINED_TEST_BEHAVIOR "Build LLVM libc tests assuming our implementation-defined behavior" ON)

option(LLVM_LIBC_ENABLE_LINTING "Enables linting of libc source files" OFF)

option(LIBC_GPU_BUILD "Build libc for the GPU. All CPU build options will be ignored." OFF)

set(LIBC_TARGET_TRIPLE "" CACHE STRING "The target triple for the libc build.")

set(LIBC_ENABLE_UNITTESTS ON)

set(LIBC_ENABLE_HERMETIC_TESTS ON)

set(LIBC_ENABLE_HERMETIC_TESTS ${LLVM_LIBC_FULL_BUILD})

jhuber6Unsubmitted

Not Done

if(LLVM_LIBC_FULL_BUILD)

- set(LIBC_ENABLE_HERMETIC_TESTS ON)

+ set(LIBC_ENABLE_HERMETIC_TESTS ${LLVM_LIBC_FULL_BUILD})

endif()

Not really important, but does this work?

jhuber6: Not really important, but does this work?

# Defines LIBC_TARGET_ARCHITECTURE and associated macros.

include(LLVMLibCArchitectures)

if(LIBC_TARGET_ARCHITECTURE_IS_GPU)

include(prepare_libc_gpu_build)

set(LIBC_ENABLE_UNITTESTS OFF)