This is an archive of the discontinued LLVM Phabricator instance.

Differential D149075

[libc][Obvious] Add include.stdlib as missing dep for CPP.string.
ClosedPublic

Authored by sivachandra on Apr 24 2023, 9:42 AM.

Details

Reviewers
jhuber6
Commits
rG23df67bdeee2: [libc][Obvious] Add include.stdlib as missing dep for CPP.string.
Summary

string.h includes stdlib.h to get free and realloc. This change
adds the missing dep on stdlib.h.

Diff Detail

Event Timeline

sivachandra created this revision.Apr 24 2023, 9:42 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 24 2023, 9:42 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.Apr 24 2023, 9:42 AM
Harbormaster completed remote builds in B227757: Diff 516444.Apr 24 2023, 9:48 AM
jhuber6 accepted this revision.Apr 24 2023, 9:52 AM
This revision is now accepted and ready to land.Apr 24 2023, 9:52 AM
sivachandra mentioned this in D148756: [libc] Add rule named `add_libc_hermetic_test` which adds a hermetic test..Apr 24 2023, 10:12 AM
Closed by commit rG23df67bdeee2: [libc][Obvious] Add include.stdlib as missing dep for CPP.string. (authored by sivachandra). · Explain WhyApr 24 2023, 3:07 PM
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rG23df67bdeee2: [libc][Obvious] Add include.stdlib as missing dep for CPP.string..

Revision Contents

PathSize
libc/
src/
__support/
CPP/
1 line

Diff 516549

libc/src/__support/CPP/CMakeLists.txt

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines DEPENDS
libc.src.__support.common libc.src.__support.common
) )
add_header_library( add_header_library(
string string
HDRS HDRS
string.h string.h
DEPENDS DEPENDS
libc.include.stdlib
.string_view .string_view
libc.src.__support.common libc.src.__support.common
libc.src.__support.integer_to_string libc.src.__support.integer_to_string
libc.src.string.memory_utils.memcpy_implementation libc.src.string.memory_utils.memcpy_implementation
libc.src.string.memory_utils.memset_implementation libc.src.string.memory_utils.memset_implementation
libc.src.string.string_utils libc.src.string.string_utils
) )
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines