This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Adds more forward declaration headers.
ClosedPublic

Authored by Mordante on Apr 21 2023, 8:25 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG9d16cbc5c8bd: [libc++] Adds more forward declaration headers.
Summary

The module validation script of D144994 validate whether the contents of
an include match its module. An include is the set of files matching the
pattern:

  • foo
  • foo/*.
  • __fwd/foo.h

Several declarations of the stream headers are in the header iosfwd.
This gives issue using the validation script. Adding iosfwd to the set
of matching files gives too many declarations. For example when
validating the fstream header it will pull in declarations of the
istream header. Instead if writing a set of filters the headers are
granularized into smaller headers containing the expected declarations.

Diff Detail

Event Timeline

Mordante created this revision.Apr 21 2023, 8:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 8:25 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante updated this revision to Diff 515753.Apr 21 2023, 8:32 AM

CI fixes.

Mordante updated this revision to Diff 515847.Apr 21 2023, 11:16 AM

Trigger CI.

Mordante updated this revision to Diff 515860.Apr 21 2023, 11:42 AM

Retrigger CI.

Mordante updated this revision to Diff 516049.Apr 22 2023, 3:13 AM

Retrigger CI.

Mordante updated this revision to Diff 516060.Apr 22 2023, 5:30 AM

CI fixes.

Mordante published this revision for review.Apr 24 2023, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2023, 11:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Apr 25 2023, 9:17 AM
This revision is now accepted and ready to land.Apr 25 2023, 9:17 AM
This revision was landed with ongoing or failed builds.Apr 27 2023, 8:07 AM
This revision was automatically updated to reflect the committed changes.