This is an archive of the discontinued LLVM Phabricator instance.

[html] Advertize the charset actually being used. NFC.
ClosedPublic

Authored by aadg on Nov 19 2015, 10:23 AM.

Download Raw Diff

Details

Reviewers

• ddunbar
cmatthews

Commits

rL258674: [html] Advertize the charset actually being used. NFC.

Summary

We currently advertize the ISO-8859-1 charset is used when we
actually use UTF-8. Let's be consistent an advertize the truth.

This is the last patch in a serie which has brought the main, machine, run and
daily_report pages into clean html (according to https://validator.w3.org/nu).

I'm however wondering if there were any reason to use ISO-8859-1, thus this request for review.

Diff Detail

Event Timeline

aadg updated this revision to Diff 40673.Nov 19 2015, 10:23 AM

aadg retitled this revision from to [html] Advertize the charset actually being used. NFC..

aadg updated this object.

aadg added reviewers: cmatthews, • ddunbar.

aadg added a subscriber: llvm-commits.

I don't see a problem with this.

This revision is now accepted and ready to land.Jan 20 2016, 5:01 PM

Closed by commit rL258674: [html] Advertize the charset actually being used. NFC. (authored by aadg). · Explain WhyJan 25 2016, 2:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lnt/

server/

ui/

templates/

layout.html

5 lines

Diff 40673

lnt/server/ui/templates/layout.html

	<!DOCTYPE html>			<!DOCTYPE html>
	<html lang="en">			<html lang="en">
	<head>			<head>
				<meta charset="UTF-8"/>
	<link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css')			<link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css')
	}}" rel="stylesheet" media="screen"/>			}}" rel="stylesheet" media="screen"/>
	<link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css')			<link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css')
	}}" rel="stylesheet"/>			}}" rel="stylesheet"/>
	<link href="{{ url_for('.static', filename='narrow.css')			<link href="{{ url_for('.static', filename='narrow.css')
	}}" rel="stylesheet" media='screen and (max-width: 750px)'/>			}}" rel="stylesheet" media='screen and (max-width: 750px)'/>
	<link href="{{ url_for('.static', filename='wide.css')			<link href="{{ url_for('.static', filename='wide.css')
	}}" rel="stylesheet" media='screen and (min-width: 750px)'/>			}}" rel="stylesheet" media='screen and (min-width: 750px)'/>
	<script src="{{ url_for('.static', filename='jquery/1.7.2/jquery-1.7.2.min.js')			<script src="{{ url_for('.static', filename='jquery/1.7.2/jquery-1.7.2.min.js')
	}}"> </script>			}}"> </script>
	<script src="{{ url_for('.static', filename='jquery/jquery.dateFormat/jquery-dateFormat.min.js')			<script src="{{ url_for('.static', filename='jquery/jquery.dateFormat/jquery-dateFormat.min.js')
	}}"> </script>			}}"> </script>

	<script src="{{ url_for('.static', filename='bootstrap/js/bootstrap.min.js')			<script src="{{ url_for('.static', filename='bootstrap/js/bootstrap.min.js')
	}}"></script>			}}"></script>
	<script src="{{ url_for('.static', filename='timedate.js')			<script src="{{ url_for('.static', filename='timedate.js')
	}}"></script>			}}"></script>

	<!-- DataTables CSS -->			<!-- DataTables CSS -->
	<link rel="stylesheet" type="text/css" href="//cdn.datatables.net/1.10.8/css/jquery.dataTables.css" />			<link rel="stylesheet" type="text/css" href="//cdn.datatables.net/1.10.8/css/jquery.dataTables.css" />

	<!-- DataTables -->			<!-- DataTables -->
	<script type="text/javascript" charset="utf8" src="//cdn.datatables.net/1.10.8/js/jquery.dataTables.js">			<script type="text/javascript" charset="UTF-8" src="//cdn.datatables.net/1.10.8/js/jquery.dataTables.js">
	</script>			</script>


	<meta name="viewport" content="width=device-width, initial-scale=1.0"/>			<meta name="viewport" content="width=device-width, initial-scale=1.0"/>
	<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>			<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>

	<style type="text/css">			<style type="text/css">
	/* Sticky footer styles ------------------------------------------------- */			/* Sticky footer styles ------------------------------------------------- */
	html,			html,
	body {			body {
	height: 100%;			height: 100%;
	/* The html and body elements cannot have any padding or margin. */			/* The html and body elements cannot have any padding or margin. */
	}			}
	▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines