This is an archive of the discontinued LLVM Phabricator instance.

Differential D148292

[LIBC] Clarify namespace of `thread_exit` in `pthread_exit`
ClosedPublic

Authored by goldstein.w.n on Apr 13 2023, 8:04 PM.

Details

Reviewers
michaelrj
sivachandra
Commits
rG442b0d9db4df: [LIBC] Clarify namespace of `thread_exit` in `pthread_exit`
Summary

Just add __llvm_libc:: to makes things clearer.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 13 2023, 8:04 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 13 2023, 8:04 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 13 2023, 8:04 PM
Harbormaster completed remote builds in B225486: Diff 513418.Apr 13 2023, 8:12 PM
sivachandra accepted this revision.Apr 13 2023, 9:40 PM
This revision is now accepted and ready to land.Apr 13 2023, 9:40 PM
Closed by commit rG442b0d9db4df: [LIBC] Clarify namespace of `thread_exit` in `pthread_exit` (authored by goldstein.w.n). · Explain WhyApr 14 2023, 11:14 AM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG442b0d9db4df: [LIBC] Clarify namespace of `thread_exit` in `pthread_exit`.

Revision Contents

PathSize
libc/
src/
pthread/
2 lines

Diff 513682

libc/src/pthread/pthread_exit.cpp

Show All 13 Lines
#include <pthread.h> // For pthread_* type definitions. #include <pthread.h> // For pthread_* type definitions.
namespace __llvm_libc { namespace __llvm_libc {
static_assert(sizeof(pthread_t) == sizeof(__llvm_libc::Thread), static_assert(sizeof(pthread_t) == sizeof(__llvm_libc::Thread),
"Mismatch between pthread_t and internal Thread."); "Mismatch between pthread_t and internal Thread.");
LLVM_LIBC_FUNCTION(void, pthread_exit, (void *retval)) { LLVM_LIBC_FUNCTION(void, pthread_exit, (void *retval)) {
thread_exit(ThreadReturnValue(retval), ThreadStyle::POSIX); __llvm_libc::thread_exit(ThreadReturnValue(retval), ThreadStyle::POSIX);
} }
} // namespace __llvm_libc } // namespace __llvm_libc