This is an archive of the discontinued LLVM Phabricator instance.

Differential D148289

[LIBC] Actually assert no errors in `pthread_call_once` in its test; NFC
ClosedPublic

Authored by goldstein.w.n on Apr 13 2023, 8:03 PM.

Details

Reviewers
michaelrj
sivachandra
Commits
rGc8a29c2dfc56: [LIBC] Actually assert no errors in `pthread_call_once` in its test; NFC
Summary

Just seemed to be missing an assertion.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 13 2023, 8:03 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 13 2023, 8:03 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 13 2023, 8:03 PM
goldstein.w.n added reviewers: michaelrj, sivachandra.Apr 13 2023, 8:06 PM
Harbormaster completed remote builds in B225483: Diff 513415.Apr 13 2023, 8:11 PM
sivachandra accepted this revision.Apr 13 2023, 9:43 PM
This revision is now accepted and ready to land.Apr 13 2023, 9:43 PM
Closed by commit rGc8a29c2dfc56: [LIBC] Actually assert no errors in `pthread_call_once` in its test; NFC (authored by goldstein.w.n). · Explain WhyApr 14 2023, 11:14 AM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGc8a29c2dfc56: [LIBC] Actually assert no errors in `pthread_call_once` in its test; NFC.

Revision Contents

PathSize
libc/
test/
integration/
src/
pthread/
2 lines

Diff 513683

libc/test/integration/src/pthread/pthread_once_test.cpp

Show All 22 Lines
static constexpr unsigned int NUM_THREADS = 5; static constexpr unsigned int NUM_THREADS = 5;
static __llvm_libc::cpp::Atomic<unsigned int> thread_count; static __llvm_libc::cpp::Atomic<unsigned int> thread_count;
static unsigned int call_count; static unsigned int call_count;
static void pthread_once_func() { ++call_count; } static void pthread_once_func() { ++call_count; }
static void *func(void *) { static void *func(void *) {
static pthread_once_t flag = PTHREAD_ONCE_INIT; static pthread_once_t flag = PTHREAD_ONCE_INIT;
__llvm_libc::pthread_once(&flag, pthread_once_func); ASSERT_EQ(__llvm_libc::pthread_once(&flag, pthread_once_func), 0);
thread_count.fetch_add(1); thread_count.fetch_add(1);
return nullptr; return nullptr;
} }
void call_from_5_threads() { void call_from_5_threads() {
// Ensure the call count and thread count are 0 to begin with. // Ensure the call count and thread count are 0 to begin with.
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines