This is an archive of the discontinued LLVM Phabricator instance.

[clang] Mark CWG2331 as N/A
ClosedPublic

Authored by Endill on Apr 13 2023, 11:12 AM.

Details

Reviewers
shafik
Group Reviewers
Restricted Project
Commits
rG19ef8e8446df: [clang] Mark CWG2331 as N/A
Summary

P1787: CWG2331 is resolved by defining lookup from complete-class contexts and out-of-line member definitions.
Wording: The declaration set is the result of a single search in the scope of C for N from immediately after the class-specifier of C if P is in a complete-class context of C or from P otherwise. ([class.member.lookup]/4)

Diff Detail

Event Timeline

Endill created this revision.Apr 13 2023, 11:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 11:12 AM
Endill requested review of this revision.Apr 13 2023, 11:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 11:12 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

The defect report has two examples even though the first one is commented incorrectly considering the final resolution. I am sure they are covered in the test suite in other places but why not add them?

The defect report has two examples even though the first one is commented incorrectly considering the final resolution. I am sure they are covered in the test suite in other places but why not add them?

My understanding of this CWG is the following. There was redundant wording. Then someone came up with wording that fixes that. Then it was identified that proposed wording is defective, and gives couple of examples, which was enough to return issue to "drafting".
What I find important here is that no behavioral changes were introduced. Those examples just give a hint what a conformance test for those paragraphs should take into account.

shafik accepted this revision.Apr 14 2023, 3:07 PM

LGTM

This revision is now accepted and ready to land.Apr 14 2023, 3:07 PM
This revision was automatically updated to reflect the committed changes.