This is an archive of the discontinued LLVM Phabricator instance.

Fix warnings in InstrProfTest.cpp
ClosedPublic

Authored by ellis on Apr 13 2023, 11:10 AM.

Details

Diff Detail

Event Timeline

ellis created this revision.Apr 13 2023, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 11:10 AM
ellis requested review of this revision.Apr 13 2023, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 11:10 AM

Sorry it looks like I broke some builds. Hopefully this will fix them.

https://lab.llvm.org/buildbot/#/builders/57/builds/26047

/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/ProfileData/InstrProfTest.cpp:252:3: error: 'SmallVector' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
  SmallVector Traces = {LargeTrace, SmallTrace};
  ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/include/llvm/ADT/SmallVector.h:1199:22: note: add a deduction guide to suppress this warning
class LLVM_GSL_OWNER SmallVector : public SmallVectorImpl<T>,
snehasish accepted this revision.Apr 13 2023, 11:15 AM

lgtm

Can you leave an example of the warnings in the review discussion here for posterity? Thanks!

This revision is now accepted and ready to land.Apr 13 2023, 11:15 AM
plotfi accepted this revision.Apr 13 2023, 11:16 AM
This revision was landed with ongoing or failed builds.Apr 13 2023, 11:16 AM
This revision was automatically updated to reflect the committed changes.