This reverts commit 89cc5304969ded574550e0ad113f59f3d4f50303.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Mostly small nits.
compiler-rt/lib/scudo/standalone/tests/common_test.cpp | ||
---|---|---|
40 | You lost the ASSERT_NE(nullptr, P) line. Even though getBase should not even return 0, it's probably worth keeping it in just in case. | |
61 | Same as above, missing P is not nullptr check. | |
compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp | ||
51 | Should there be a check that Addr is non-zero? | |
66 | Technically, you don't do this any other place because MemMap is already initialized properly. Doesn't matter if you leave this or not though. |
Address review comment
compiler-rt/lib/scudo/standalone/tests/common_test.cpp | ||
---|---|---|
40 | Good catch! | |
compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp | ||
66 | Right, just added because of some weird bug only happens on Android (Which I need to add {} for MemMap). Just in case it complains again and in order to make the style consistent. |
You lost the ASSERT_NE(nullptr, P) line. Even though getBase should not even return 0, it's probably worth keeping it in just in case.