This is an archive of the discontinued LLVM Phabricator instance.

Differential D147631

[libunwind] Fix a typo in a debug log message. NFC.
ClosedPublic

Authored by mstorsjo on Apr 5 2023, 9:41 AM.

Details

Reviewers
compnerd
Group Reviewers
Restricted Project
Commits
rGa017aefeac9c: [libunwind] Fix a typo in a debug log message. NFC.
Summary

This typo (unw_step instead of unw_get_proc_info) has been around since
the initial public commit of libunwind.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 5 2023, 9:41 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 5 2023, 9:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Apr 5 2023, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 9:41 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B223826: Diff 511134.Apr 5 2023, 2:23 PM
compnerd accepted this revision.Apr 5 2023, 3:51 PM
This revision is now accepted and ready to land.Apr 5 2023, 3:51 PM
This revision was landed with ongoing or failed builds.Apr 6 2023, 1:09 AM
Closed by commit rGa017aefeac9c: [libunwind] Fix a typo in a debug log message. NFC. (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGa017aefeac9c: [libunwind] Fix a typo in a debug log message. NFC..

Revision Contents

PathSize
libunwind/
src/
2 lines
2 lines
2 lines

Diff 511311

libunwind/src/Unwind-EHABI.cpp

Show First 20 Lines • Show All 703 Lines • ▼ Show 20 Linesunwind_phase2_forced(unw_context_t *uc, unw_cursor_t *cursor,
__unw_init_local(cursor, uc); __unw_init_local(cursor, uc);
_LIBUNWIND_TRACE_UNWINDING("unwind_phase2_force(ex_ojb=%p)", _LIBUNWIND_TRACE_UNWINDING("unwind_phase2_force(ex_ojb=%p)",
static_cast<void *>(exception_object)); static_cast<void *>(exception_object));
// Walk each frame until we reach where search phase said to stop // Walk each frame until we reach where search phase said to stop
while (!endOfStack) { while (!endOfStack) {
// Update info about this frame. // Update info about this frame.
unw_proc_info_t frameInfo; unw_proc_info_t frameInfo;
if (__unw_get_proc_info(cursor, &frameInfo) != UNW_ESUCCESS) { if (__unw_get_proc_info(cursor, &frameInfo) != UNW_ESUCCESS) {
_LIBUNWIND_TRACE_UNWINDING("unwind_phase2_forced(ex_ojb=%p): __unw_step " _LIBUNWIND_TRACE_UNWINDING("unwind_phase2_forced(ex_ojb=%p): __unw_get_proc_info "
"failed => _URC_END_OF_STACK", "failed => _URC_END_OF_STACK",
(void *)exception_object); (void *)exception_object);
return _URC_FATAL_PHASE2_ERROR; return _URC_FATAL_PHASE2_ERROR;
} }
#ifndef NDEBUG #ifndef NDEBUG
// When tracing, print state information. // When tracing, print state information.
if (_LIBUNWIND_TRACING_UNWINDING) { if (_LIBUNWIND_TRACING_UNWINDING) {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines

libunwind/src/Unwind-seh.cpp

Show First 20 Lines • Show All 232 Lines • ▼ Show 20 Linesunwind_phase2_forced(unw_context_t *uc,
__unw_init_local(&cursor2, uc); __unw_init_local(&cursor2, uc);
// Walk each frame until we reach where search phase said to stop // Walk each frame until we reach where search phase said to stop
while (__unw_step(&cursor2) > 0) { while (__unw_step(&cursor2) > 0) {
// Update info about this frame. // Update info about this frame.
unw_proc_info_t frameInfo; unw_proc_info_t frameInfo;
if (__unw_get_proc_info(&cursor2, &frameInfo) != UNW_ESUCCESS) { if (__unw_get_proc_info(&cursor2, &frameInfo) != UNW_ESUCCESS) {
_LIBUNWIND_TRACE_UNWINDING("unwind_phase2_forced(ex_ojb=%p): __unw_step " _LIBUNWIND_TRACE_UNWINDING("unwind_phase2_forced(ex_ojb=%p): __unw_get_proc_info "
"failed => _URC_END_OF_STACK", "failed => _URC_END_OF_STACK",
(void *)exception_object); (void *)exception_object);
return _URC_FATAL_PHASE2_ERROR; return _URC_FATAL_PHASE2_ERROR;
} }
#ifndef NDEBUG #ifndef NDEBUG
// When tracing, print state information. // When tracing, print state information.
if (_LIBUNWIND_TRACING_UNWINDING) { if (_LIBUNWIND_TRACING_UNWINDING) {
▲ Show 20 Lines • Show All 242 Lines • Show Last 20 Lines

libunwind/src/UnwindLevel1.c

Show First 20 Lines • Show All 315 Lines • ▼ Show 20 Linesunwind_phase2_forced(unw_context_t *uc, unw_cursor_t *cursor,
unsigned framesWalked = 1; unsigned framesWalked = 1;
// Walk each frame until we reach where search phase said to stop // Walk each frame until we reach where search phase said to stop
while (__unw_step_stage2(cursor) > 0) { while (__unw_step_stage2(cursor) > 0) {
// Update info about this frame. // Update info about this frame.
unw_proc_info_t frameInfo; unw_proc_info_t frameInfo;
if (__unw_get_proc_info(cursor, &frameInfo) != UNW_ESUCCESS) { if (__unw_get_proc_info(cursor, &frameInfo) != UNW_ESUCCESS) {
_LIBUNWIND_TRACE_UNWINDING( _LIBUNWIND_TRACE_UNWINDING(
"unwind_phase2_forced(ex_obj=%p): __unw_step_stage2 " "unwind_phase2_forced(ex_obj=%p): __unw_get_proc_info "
"failed => _URC_END_OF_STACK", "failed => _URC_END_OF_STACK",
(void *)exception_object); (void *)exception_object);
return _URC_FATAL_PHASE2_ERROR; return _URC_FATAL_PHASE2_ERROR;
} }
#ifndef NDEBUG #ifndef NDEBUG
// When tracing, print state information. // When tracing, print state information.
if (_LIBUNWIND_TRACING_UNWINDING) { if (_LIBUNWIND_TRACING_UNWINDING) {
▲ Show 20 Lines • Show All 255 Lines • Show Last 20 Lines