This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Check for C++ headers before building a test that uses them
ClosedPublic

Authored by mstorsjo on Apr 5 2023, 9:40 AM.

Details

Summary

When the libcxx test framework is executed within libunwind, there
are no standard C++ headers available (libunwind builds with
-nostdinc++, but doesn't add any libcxx headers to the include path).

Check that a test that includes <iostream> can be compiled before trying
to build and execute a test program that includes it.

Previously, the compile error here would block all libunwind tests from
executing altogether.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 5 2023, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 9:40 AM
Herald added a subscriber: arichardson. · View Herald Transcript
mstorsjo requested review of this revision.Apr 5 2023, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 9:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
EricWF accepted this revision.Apr 11 2023, 11:05 AM
This revision is now accepted and ready to land.Apr 11 2023, 11:05 AM
This revision was landed with ongoing or failed builds.Apr 12 2023, 12:18 AM
This revision was automatically updated to reflect the committed changes.