[NewPM] Use PassID instead of pass name

[pchintalapudi]

Summary

PrintIRInstrumentation::shouldPrintAfterPass accepts a pass ID instead of a pass name

[aeubanks]

lg, but can you add a test?

[pchintalapudi]

How do I go about adding a regression test for this? I have a simple reproducer here: https://godbolt.org/z/nEK139rEo

[aeubanks]

something along the lines of llvm/test/Other/loop-pass-printer.ll with the IR and opt command you have should be good

[pchintalapudi]

Add test

[aeubanks]

some test nits, otherwise lgtm
do you need me to land this for you?

llvm/test/Other/loop-print-after-pass-invalidated.ll

3

5

there's no DEL check prefix in the test?

[aeubanks]

also the added test fails according to the premerge checks

[pchintalapudi]

Fix test

[aeubanks]

lg with one more test fix

llvm/test/Other/loop-print-after-pass-invalidated.ll

3

this suggested fix is still relevant

[pchintalapudi]

Simplify opt arguments

[pchintalapudi]

do you need me to land this for you?

Yes please,

Name: Prem Chintalapudi
Email: [e-mail]

llvm/lib/Passes/StandardInstrumentations.cpp

void PrintIRInstrumentation::printAfterPass(StringRef PassID, Any IR) {
   if (!shouldPrintIR(IR))
     return;
 
   dbgs() << "*** IR Dump After " << PassID << " on " << IRName << " ***\n";
   unwrapAndPrint(dbgs(), IR);
 }
 
 void PrintIRInstrumentation::printAfterPassInvalidated(StringRef PassID) {
-  StringRef PassName = PIC->getPassNameForClassName(PassID);
-  if (!shouldPrintAfterPass(PassName))
+  if (!shouldPrintAfterPass(PassID))
     return;
 
   if (isIgnored(PassID))
     return;
 
   const Module *M;
   std::string IRName;
   StringRef StoredPassID;

llvm/test/Other/loop-print-after-pass-invalidated.ll

+; RUN: opt < %s 2>&1 -disable-output \
+; RUN:     -passes='simple-loop-unswitch<nontrivial>' \
+; RUN:     -print-after=simple-loop-unswitch \
+; RUN:     | FileCheck %s
+
+; CHECK: *** IR Dump After SimpleLoopUnswitchPass on for.cond ***
+; CHECK: *** IR Dump After SimpleLoopUnswitchPass on for.cond.us ***
+
+define void @loop(i1 %w)  {
+entry:
+  br label %for.cond
+; Loop:
+for.cond:                                         ; preds = %for.inc, %entry
+  br i1 %w, label %for.inc, label %if.then
+
+if.then:                                          ; preds = %for.cond
+  br label %for.inc
+
+for.inc:                                          ; preds = %if.then, %for.cond
+  br label %for.cond
+}