Page MenuHomePhabricator

Reland "[scudo] Add a Timer class to assist performance measurement"

Authored by Chia-hungDuan on Mar 23 2023, 5:05 PM.

Diff Detail

Event Timeline

Chia-hungDuan created this revision.Mar 23 2023, 5:05 PM
Chia-hungDuan requested review of this revision.Mar 23 2023, 5:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 5:05 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Remove the virtual specifier on Timer's destructor. That caused the problem (

Also fix some uses of uptr with u64 which aligns the type used by getMonoticTime()

Add header guard

cferris requested changes to this revision.Apr 3 2023, 1:42 PM

One small question.


Should this be u64 too?

This revision now requires changes to proceed.Apr 3 2023, 1:42 PM
Chia-hungDuan marked an inline comment as done.

Address review comment and rebase

cferris accepted this revision.Apr 3 2023, 3:16 PM


This revision is now accepted and ready to land.Apr 3 2023, 3:16 PM