Introducing xor key to derive unmangled sp is here to follow the way
that the glibc adds support for pointer mangling on loongarch in commit
1c9bc1b6e50293a1b7037a7bfbf835868a55baed.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Without this change, there are eight failed tests:
$ make check-tsan Failed Tests (8): ThreadSanitizer-loongarch64 :: exceptions.cpp ThreadSanitizer-loongarch64 :: fiber_longjmp.cpp ThreadSanitizer-loongarch64 :: ignore_lib4.cpp ThreadSanitizer-loongarch64 :: longjmp.cpp ThreadSanitizer-loongarch64 :: longjmp2.cpp ThreadSanitizer-loongarch64 :: longjmp3.cpp ThreadSanitizer-loongarch64 :: longjmp4.cpp ThreadSanitizer-loongarch64 :: signal_longjmp.cpp Testing Time: 151.22s Unsupported : 91 Passed : 338 Expectedly Failed: 2 Failed : 8
With this change, tests all pass:
$ make check-tsan Testing Time: 238.30s Unsupported : 91 Passed : 346 Expectedly Failed: 2
compiler-rt/lib/tsan/rtl/tsan_platform_linux.cpp | ||
---|---|---|
69–70 | Yes. |
compiler-rt/lib/tsan/rtl/tsan_platform_linux.cpp | ||
---|---|---|
391 | Does this condition need to be changed to __loongarch_lp64? |
compiler-rt/lib/tsan/rtl/tsan_platform_linux.cpp | ||
---|---|---|
391 | Yes. |
Should be __loongarch_lp64 since we don't know whether loongarch32 needs it?