This is an archive of the discontinued LLVM Phabricator instance.

Differential D146462

[libc][obvious] fix missing memory_check_utils
ClosedPublic

Authored by michaelrj on Mar 20 2023, 3:06 PM.

Details

Reviewers
None
Commits
rGf2c3a9cbd229: [libc][obvious] fix missing memory_check_utils
Summary

memmove and bcopy tests were missing a dependancy on memory_check_utils
in the bazel build, causing build failures.

Diff Detail

Event Timeline

michaelrj created this revision.Mar 20 2023, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 3:06 PM
Herald added subscribers: mikhail.ramalho, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Mar 20 2023, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 3:06 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2023, 3:07 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGf2c3a9cbd229: [libc][obvious] fix missing memory_check_utils (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGf2c3a9cbd229: [libc][obvious] fix missing memory_check_utils.
Harbormaster completed remote builds in B220562: Diff 506744.Mar 20 2023, 3:14 PM

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
libc/
test/
src/
string/
2 lines

Diff 506745

utils/bazel/llvm-project-overlay/libc/test/src/string/BUILD.bazel

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lineslibc_test(
srcs = ["memmove_test.cpp"], srcs = ["memmove_test.cpp"],
libc_function_deps = [ libc_function_deps = [
"//libc:memcmp", "//libc:memcmp",
"//libc:memmove", "//libc:memmove",
], ],
deps = [ deps = [
"//libc:__support_cpp_span", "//libc:__support_cpp_span",
"//libc/test/UnitTest:memory_matcher", "//libc/test/UnitTest:memory_matcher",
":memory_check_utils",
], ],
) )
libc_test( libc_test(
name = "bcopy_test", name = "bcopy_test",
srcs = ["bcopy_test.cpp"], srcs = ["bcopy_test.cpp"],
libc_function_deps = [ libc_function_deps = [
"//libc:bcopy", "//libc:bcopy",
], ],
deps = [ deps = [
"//libc:__support_cpp_span", "//libc:__support_cpp_span",
"//libc/test/UnitTest:memory_matcher", "//libc/test/UnitTest:memory_matcher",
":memory_check_utils",
], ],
) )
libc_test( libc_test(
name = "memcmp_test", name = "memcmp_test",
srcs = ["memcmp_test.cpp"], srcs = ["memcmp_test.cpp"],
libc_function_deps = [ libc_function_deps = [
"//libc:memcmp", "//libc:memcmp",
Show All 21 Lines