This is an archive of the discontinued LLVM Phabricator instance.

Differential D146384

[libc++] Change linkage for some functions.
ClosedPublic

Authored by Mordante on Mar 19 2023, 10:08 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG40f2f2f55189: [libc++] Change linkage for some functions.
Summary

Internal linkages fails when building libc++ with modules. Using
internal linkage is headers seems questionable to change the linkage.

Diff Detail

Unit TestsFailed

TimeTest
270 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_array::new_align_val_t_nothrow.pass.cpp
260 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_array::new_array_nothrow.pass.cpp
290 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_single::new_align_val_t_nothrow.pass.cpp
260 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_single::new_nothrow.pass.cpp

Event Timeline

Mordante created this revision.Mar 19 2023, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2023, 10:08 AM
Herald added a subscriber: mikhail.ramalho. · View Herald Transcript
Mordante requested review of this revision.Mar 19 2023, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2023, 10:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Mar 19 2023, 10:44 AM
This revision is now accepted and ready to land.Mar 19 2023, 10:44 AM
Harbormaster completed remote builds in B220304: Diff 506405.Mar 19 2023, 11:47 AM
This revision was landed with ongoing or failed builds.Mar 19 2023, 11:50 AM
Closed by commit rG40f2f2f55189: [libc++] Change linkage for some functions. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG40f2f2f55189: [libc++] Change linkage for some functions..

Revision Contents

PathSize
libcxx/
include/
__algorithm/
2 lines
2 lines

Diff 506405

libcxx/include/__algorithm/ranges_find_if.h

Show All 25 Lines
#if _LIBCPP_STD_VER >= 20 #if _LIBCPP_STD_VER >= 20
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
namespace ranges { namespace ranges {
template <class _Ip, class _Sp, class _Pred, class _Proj> template <class _Ip, class _Sp, class _Pred, class _Proj>
_LIBCPP_HIDE_FROM_ABI static constexpr _LIBCPP_HIDE_FROM_ABI constexpr
_Ip __find_if_impl(_Ip __first, _Sp __last, _Pred& __pred, _Proj& __proj) { _Ip __find_if_impl(_Ip __first, _Sp __last, _Pred& __pred, _Proj& __proj) {
for (; __first != __last; ++__first) { for (; __first != __last; ++__first) {
if (std::invoke(__pred, std::invoke(__proj, *__first))) if (std::invoke(__pred, std::invoke(__proj, *__first)))
break; break;
} }
return __first; return __first;
} }
Show All 29 Lines

libcxx/include/__algorithm/ranges_min_element.h

Show All 26 Lines
#if _LIBCPP_STD_VER >= 20 #if _LIBCPP_STD_VER >= 20
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
namespace ranges { namespace ranges {
// TODO(ranges): `ranges::min_element` can now simply delegate to `std::__min_element`. // TODO(ranges): `ranges::min_element` can now simply delegate to `std::__min_element`.
template <class _Ip, class _Sp, class _Proj, class _Comp> template <class _Ip, class _Sp, class _Proj, class _Comp>
_LIBCPP_HIDE_FROM_ABI static constexpr _LIBCPP_HIDE_FROM_ABI constexpr
_Ip __min_element_impl(_Ip __first, _Sp __last, _Comp& __comp, _Proj& __proj) { _Ip __min_element_impl(_Ip __first, _Sp __last, _Comp& __comp, _Proj& __proj) {
if (__first == __last) if (__first == __last)
return __first; return __first;
_Ip __i = __first; _Ip __i = __first;
while (++__i != __last) while (++__i != __last)
if (std::invoke(__comp, std::invoke(__proj, *__i), std::invoke(__proj, *__first))) if (std::invoke(__comp, std::invoke(__proj, *__i), std::invoke(__proj, *__first)))
__first = __i; __first = __i;
Show All 31 Lines