This is an archive of the discontinued LLVM Phabricator instance.

Differential D146378

[runtimes] Don't use -Wall on clang-cl builds
ClosedPublic

Authored by philnik on Mar 19 2023, 2:16 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Restricted Project
Commits
rGe6cc0faa7382: [runtimes] Don't use -Wall on clang-cl builds
Summary

-Wall on clang-cl is equivalent to -Weverything on clang. We already add the correct warning flag depending whether we are in an MSVC-like environment, so just remove it from the list of flags that get passed unconditionally.

Diff Detail

Event Timeline

philnik created this revision.Mar 19 2023, 2:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2023, 2:16 AM
philnik requested review of this revision.Mar 19 2023, 2:16 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 19 2023, 2:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik updated this revision to Diff 506369.Mar 19 2023, 2:48 AM

Other fix

philnik retitled this revision from [runtimes] Disable -Wreserved-identitifer on clang-cl builds to [runtimes] Don't use -Wall on clang-cl builds.Mar 19 2023, 2:51 AM
philnik edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B220279: Diff 506369.Mar 19 2023, 4:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2023, 4:51 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGe6cc0faa7382: [runtimes] Don't use -Wall on clang-cl builds (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rGe6cc0faa7382: [runtimes] Don't use -Wall on clang-cl builds.

Revision Contents

PathSize
runtimes/
cmake/
Modules/
1 line

Diff 506363

runtimes/cmake/Modules/WarningFlags.cmake

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines if (LIBCXX_TARGETING_CLANG_CL)
-Wno-gcc-compat # For ignoring "'diagnose_if' is a clang extension" warnings -Wno-gcc-compat # For ignoring "'diagnose_if' is a clang extension" warnings
-Wno-zero-as-null-pointer-constant # FIXME: Remove this and fix all occurrences. -Wno-zero-as-null-pointer-constant # FIXME: Remove this and fix all occurrences.
-Wno-deprecated-dynamic-exception-spec # For auto_ptr -Wno-deprecated-dynamic-exception-spec # For auto_ptr
-Wno-sign-conversion -Wno-sign-conversion
-Wno-old-style-cast -Wno-old-style-cast
-Wno-deprecated # FIXME: Remove this and fix all occurrences. -Wno-deprecated # FIXME: Remove this and fix all occurrences.
-Wno-shift-sign-overflow # FIXME: Why do we need this with clang-cl but not clang? -Wno-shift-sign-overflow # FIXME: Why do we need this with clang-cl but not clang?
-Wno-double-promotion # FIXME: remove me -Wno-double-promotion # FIXME: remove me
-Wno-reserved-identifier
) )
endif() endif()
elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")
target_add_compile_flags_if_supported(${target} PRIVATE target_add_compile_flags_if_supported(${target} PRIVATE
-Wstrict-aliasing=2 -Wstrict-aliasing=2
-Wstrict-overflow=4 -Wstrict-overflow=4
Show All 20 Lines